From: David Miller <davem@davemloft.net>
To: nicolas.dichtel@6wind.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] vxlan: fix test which detect duplicate vxlan iface
Date: Sat, 09 Jan 2016 21:05:09 -0500 (EST) [thread overview]
Message-ID: <20160109.210509.939212619090970717.davem@davemloft.net> (raw)
In-Reply-To: <1452162413-4227-1-git-send-email-nicolas.dichtel@6wind.com>
From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Date: Thu, 7 Jan 2016 11:26:53 +0100
> When a vxlan interface is created, the driver checks that there is not
> another vxlan interface with the same properties. To do this, it checks
> the existing vxlan udp socket. Since commit 1c51a9159dde, the creation of
> the vxlan socket is done only when the interface is set up, thus it breaks
> that test.
>
> Example:
> $ ip l a vxlan10 type vxlan id 10 group 239.0.0.10 dev eth0 dstport 0
> $ ip l a vxlan11 type vxlan id 10 group 239.0.0.10 dev eth0 dstport 0
> $ ip -br l | grep vxlan
> vxlan10 DOWN f2:55:1c:6a:fb:00 <BROADCAST,MULTICAST>
> vxlan11 DOWN 7a:cb:b9:38:59:0d <BROADCAST,MULTICAST>
>
> Instead of checking sockets, let's loop over the vxlan iface list.
>
> Fixes: 1c51a9159dde ("vxlan: fix race caused by dropping rtnl_unlock")
> Reported-by: Thomas Faivre <thomas.faivre@6wind.com>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2016-01-10 2:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 10:26 [PATCH net] vxlan: fix test which detect duplicate vxlan iface Nicolas Dichtel
2016-01-10 2:05 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160109.210509.939212619090970717.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).