netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: ogerlitz@mellanox.com
Cc: netdev@vger.kernel.org, dledford@redhat.com, matanb@mellanox.com,
	maorg@mellanox.com, saeedm@mellanox.com, eranbe@mellanox.com
Subject: Re: [PATCH for-net V2 00/12] net/mlx5_core: Enhance flow steering support
Date: Sun, 10 Jan 2016 17:05:24 -0500 (EST)	[thread overview]
Message-ID: <20160110.170524.1947409913228474436.davem@davemloft.net> (raw)
In-Reply-To: <1452415189-27950-1-git-send-email-ogerlitz@mellanox.com>

From: Or Gerlitz <ogerlitz@mellanox.com>
Date: Sun, 10 Jan 2016 10:39:37 +0200

> v1 --> v2 changes:
>   - made sure that service functions added in the IB driver are only static-fied 
>     on the last commit, to make sure bisection with -Werror works fine.

Please don't do this.  This looks rediculous.

Instead, if this kind of dependency exists in a source file, simply
add the new functions in the same commit that adds the usage of
them.

  parent reply	other threads:[~2016-01-10 22:05 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-10  8:39 [PATCH for-net V2 00/12] net/mlx5_core: Enhance flow steering support Or Gerlitz
2016-01-10  8:39 ` [PATCH net-next V2 01/12] net/mlx5_core: Introduce flow steering autogrouped flow table Or Gerlitz
2016-01-10  8:39 ` [PATCH net-next V2 02/12] net/mlx5_core: Add utilities to find next and prev flow-tables Or Gerlitz
2016-01-10  8:39 ` [PATCH net-next V2 03/12] net/mlx5_core: Managing root flow table Or Gerlitz
2016-01-10  8:39 ` [PATCH net-next V2 04/12] net/mlx5_core: Introduce modify flow table command Or Gerlitz
2016-01-10  8:39 ` [PATCH net-next V2 05/12] net/mlx5_core: Connect flow tables Or Gerlitz
2016-01-10  8:39 ` [PATCH net-next V2 06/12] net/mlx5_core: Set priority attributes Or Gerlitz
2016-01-10  8:39 ` [PATCH net-next V2 07/12] net/mlx5_core: Initialize namespaces only when supported by device Or Gerlitz
2016-01-10  8:39 ` [PATCH net-next V2 08/12] net/mlx5_core: Enable flow steering support for the IB driver Or Gerlitz
2016-01-10  8:39 ` [PATCH net-next V2 09/12] net/mlx5_core: Make ipv4/ipv6 location more clear Or Gerlitz
2016-01-11 12:17   ` David Laight
2016-01-11 13:06     ` Matan Barak
2016-01-11 13:18     ` Or Gerlitz
2016-01-10  8:39 ` [PATCH net-next V2 10/12] net/mlx5_core: Export flow steering API Or Gerlitz
2016-01-10  8:39 ` [PATCH net-next V2 11/12] IB/mlx5: Add flow steering utilities Or Gerlitz
2016-01-10  8:39 ` [PATCH net-next V2 12/12] IB/mlx5: Add flow steering support Or Gerlitz
2016-01-10  8:46 ` [PATCH for-net V2 00/12] net/mlx5_core: Enhance " Or Gerlitz
2016-01-10 22:05 ` David Miller [this message]
2016-01-11  4:15   ` Or Gerlitz
2016-01-11  8:24     ` Or Gerlitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160110.170524.1947409913228474436.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dledford@redhat.com \
    --cc=eranbe@mellanox.com \
    --cc=maorg@mellanox.com \
    --cc=matanb@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=ogerlitz@mellanox.com \
    --cc=saeedm@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).