* [PATCH] net: lpc_eth: Remove unused variables
@ 2016-01-08 12:19 Fabio Estevam
2016-01-08 15:58 ` Andrew Lunn
2016-01-11 3:50 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2016-01-08 12:19 UTC (permalink / raw)
To: davem; +Cc: andrew, netdev, Fabio Estevam
From: Fabio Estevam <fabio.estevam@nxp.com>
Commit e7f4dc3536a400 ("mdio: Move allocation of interrupts into core")
introduced the following build warnings:
drivers/net/ethernet/nxp/lpc_eth.c: In function 'lpc_mii_init':
drivers/net/ethernet/nxp/lpc_eth.c:865:1: warning: label 'err_out_1' defined but not used [-Wunused-label]
drivers/net/ethernet/nxp/lpc_eth.c:826:20: warning: unused variable 'i' [-Wunused-variable]
Remove the unused variables to fix them.
Reported-by: Olof's autobuilder <build@lixom.net>
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
drivers/net/ethernet/nxp/lpc_eth.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp/lpc_eth.c
index a9ce37f..b1ce7aa 100644
--- a/drivers/net/ethernet/nxp/lpc_eth.c
+++ b/drivers/net/ethernet/nxp/lpc_eth.c
@@ -823,7 +823,7 @@ static int lpc_mii_probe(struct net_device *ndev)
static int lpc_mii_init(struct netdata_local *pldat)
{
- int err = -ENXIO, i;
+ int err = -ENXIO;
pldat->mii_bus = mdiobus_alloc();
if (!pldat->mii_bus) {
@@ -862,7 +862,6 @@ static int lpc_mii_init(struct netdata_local *pldat)
err_out_unregister_bus:
mdiobus_unregister(pldat->mii_bus);
-err_out_1:
mdiobus_free(pldat->mii_bus);
err_out:
return err;
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: lpc_eth: Remove unused variables
2016-01-08 12:19 [PATCH] net: lpc_eth: Remove unused variables Fabio Estevam
@ 2016-01-08 15:58 ` Andrew Lunn
2016-01-11 3:50 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2016-01-08 15:58 UTC (permalink / raw)
To: Fabio Estevam; +Cc: davem, netdev, Fabio Estevam
On Fri, Jan 08, 2016 at 10:19:16AM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Commit e7f4dc3536a400 ("mdio: Move allocation of interrupts into core")
> introduced the following build warnings:
>
> drivers/net/ethernet/nxp/lpc_eth.c: In function 'lpc_mii_init':
> drivers/net/ethernet/nxp/lpc_eth.c:865:1: warning: label 'err_out_1' defined but not used [-Wunused-label]
> drivers/net/ethernet/nxp/lpc_eth.c:826:20: warning: unused variable 'i' [-Wunused-variable]
>
> Remove the unused variables to fix them.
>
> Reported-by: Olof's autobuilder <build@lixom.net>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Acked-by: Andrew Lunn <andrew@lunn.ch>
Andrew
> ---
> drivers/net/ethernet/nxp/lpc_eth.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp/lpc_eth.c
> index a9ce37f..b1ce7aa 100644
> --- a/drivers/net/ethernet/nxp/lpc_eth.c
> +++ b/drivers/net/ethernet/nxp/lpc_eth.c
> @@ -823,7 +823,7 @@ static int lpc_mii_probe(struct net_device *ndev)
>
> static int lpc_mii_init(struct netdata_local *pldat)
> {
> - int err = -ENXIO, i;
> + int err = -ENXIO;
>
> pldat->mii_bus = mdiobus_alloc();
> if (!pldat->mii_bus) {
> @@ -862,7 +862,6 @@ static int lpc_mii_init(struct netdata_local *pldat)
>
> err_out_unregister_bus:
> mdiobus_unregister(pldat->mii_bus);
> -err_out_1:
> mdiobus_free(pldat->mii_bus);
> err_out:
> return err;
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: lpc_eth: Remove unused variables
2016-01-08 12:19 [PATCH] net: lpc_eth: Remove unused variables Fabio Estevam
2016-01-08 15:58 ` Andrew Lunn
@ 2016-01-11 3:50 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-01-11 3:50 UTC (permalink / raw)
To: festevam; +Cc: andrew, netdev, fabio.estevam
From: Fabio Estevam <festevam@gmail.com>
Date: Fri, 8 Jan 2016 10:19:16 -0200
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Commit e7f4dc3536a400 ("mdio: Move allocation of interrupts into core")
> introduced the following build warnings:
>
> drivers/net/ethernet/nxp/lpc_eth.c: In function 'lpc_mii_init':
> drivers/net/ethernet/nxp/lpc_eth.c:865:1: warning: label 'err_out_1' defined but not used [-Wunused-label]
> drivers/net/ethernet/nxp/lpc_eth.c:826:20: warning: unused variable 'i' [-Wunused-variable]
>
> Remove the unused variables to fix them.
>
> Reported-by: Olof's autobuilder <build@lixom.net>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Applied, thanks Fabio.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-11 3:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-08 12:19 [PATCH] net: lpc_eth: Remove unused variables Fabio Estevam
2016-01-08 15:58 ` Andrew Lunn
2016-01-11 3:50 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).