From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: davej@codemonkey.org.uk, netdev@vger.kernel.org
Subject: Re: [PATCH net] ipv6: tcp: add rcu locking in tcp_v6_send_synack()
Date: Sun, 10 Jan 2016 22:59:53 -0500 (EST) [thread overview]
Message-ID: <20160110.225953.2100331012103485299.davem@davemloft.net> (raw)
In-Reply-To: <1452274551.8255.232.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 08 Jan 2016 09:35:51 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> When first SYNACK is sent, we already hold rcu_read_lock(), but this
> is not true if a SYNACK is retransmitted, as a timer (soft) interrupt
> does not hold rcu_read_lock()
>
> Fixes: 45f6fad84cc30 ("ipv6: add complete rcu protection around np->opt")
> Reported-by: Dave Jones <davej@codemonkey.org.uk>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied and queued up for -stable, thanks Eric.
prev parent reply other threads:[~2016-01-11 3:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 15:32 suspicious rcu_dereference in tcp_v6_send_synack Dave Jones
2016-01-07 15:52 ` Eric Dumazet
2016-01-07 16:20 ` Paul E. McKenney
2016-01-07 17:37 ` Eric Dumazet
2016-01-08 17:35 ` [PATCH net] ipv6: tcp: add rcu locking in tcp_v6_send_synack() Eric Dumazet
2016-01-11 3:59 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160110.225953.2100331012103485299.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=davej@codemonkey.org.uk \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).