From: David Miller <davem@davemloft.net>
To: sploving1@gmail.com
Cc: sergei.shtylyov@cogentembedded.com, netdev@vger.kernel.org
Subject: Re: [PATCH v2] netlink: fix null pointer dereference on nlk->groups
Date: Sun, 10 Jan 2016 23:27:07 -0500 (EST) [thread overview]
Message-ID: <20160110.232707.1954364745984617361.davem@davemloft.net> (raw)
In-Reply-To: <1452355001-30295-1-git-send-email-sploving1@gmail.com>
From: Baozeng Ding <sploving1@gmail.com>
Date: Sat, 9 Jan 2016 23:56:41 +0800
> If groups is not 0 and nlk->groups is NULL, it will not return
> immediately and cause a null pointer dereference later.
>
> Signed-off-by: Baozeng Ding <sploving1@gmail.com>
> ---
> This version uses the preferred networking coding style. Thanks
> for Sergei's feedback. Also the patch keeps the original author's
> coding style as much as possible.
Is this an actual legal state? If not, add a WARN_ON() check.
Otherwise, provide a proper OOPS log and explain how the state
can be achieved.
Thanks.
next prev parent reply other threads:[~2016-01-11 4:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 5:46 [PATCH] netlink: fix null pointer dereference on nlk->groups Baozeng Ding
2016-01-08 19:43 ` Sergei Shtylyov
2016-01-09 15:56 ` [PATCH v2] " Baozeng Ding
2016-01-11 4:27 ` David Miller [this message]
2016-01-12 11:10 ` [PATCH v3] " Baozeng Ding
2016-01-12 11:15 ` Denis Kirjanov
2016-01-12 12:00 ` Herbert Xu
2016-01-12 19:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160110.232707.1954364745984617361.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=sploving1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).