From: David Miller <davem@davemloft.net>
To: manjeet.p@samsung.com
Cc: paul.gortmaker@windriver.com, schmitzmic@gmail.com,
geert@linux-m68k.org, nico@fluxnic.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, akhilesh.k@samsung.com,
pankaj.m@samsung.com
Subject: Re: [PATCH 1/1] smsc: Enabling SMSC LAN911 driver for ARM64 as well.
Date: Mon, 11 Jan 2016 17:45:47 -0500 (EST) [thread overview]
Message-ID: <20160111.174547.403936696977744988.davem@davemloft.net> (raw)
In-Reply-To: <1452502945-27765-1-git-send-email-manjeet.p@samsung.com>
From: Manjeet Pawar <manjeet.p@samsung.com>
Date: Mon, 11 Jan 2016 14:32:25 +0530
> This patch enable network driver support for ARM64
>
> Signed-off-by: Akhilesh Kumar <akhilesh.k@samsung.com>
> Signed-off-by: Manjeet Pawar <manjeet.p@samsung.com>
There is no _WAY_ this is valid.
This driver casts skb->data pointers to "u32" integers
and then casts it back to a pointer and proceeds to
dereference that pointer.
I don't think you even looked at the build when trying to
compile this on a 64-bit machine.
That makes me have absolutely no confidence in the changes
you submit to me.
prev parent reply other threads:[~2016-01-11 22:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 9:02 [PATCH 1/1] smsc: Enabling SMSC LAN911 driver for ARM64 as well Manjeet Pawar
2016-01-11 14:10 ` Sergei Shtylyov
2016-01-11 15:16 ` Paul Gortmaker
2016-01-11 22:32 ` kbuild test robot
2016-01-11 22:45 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160111.174547.403936696977744988.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akhilesh.k@samsung.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manjeet.p@samsung.com \
--cc=netdev@vger.kernel.org \
--cc=nico@fluxnic.net \
--cc=pankaj.m@samsung.com \
--cc=paul.gortmaker@windriver.com \
--cc=schmitzmic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).