From: Jiri Pirko <jiri@resnulli.us>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, idosch@mellanox.com, eladr@mellanox.com,
yotamg@mellanox.com, ogerlitz@mellanox.com
Subject: Re: [patch net] mlxsw: spectrum: Add FDB lock to prevent session interleaving
Date: Mon, 11 Jan 2016 09:41:36 +0100 [thread overview]
Message-ID: <20160111084135.GA2246@nanopsycho.orion> (raw)
In-Reply-To: <20160111.002103.979291218776108297.davem@davemloft.net>
Mon, Jan 11, 2016 at 06:21:03AM CET, davem@davemloft.net wrote:
>From: Jiri Pirko <jiri@resnulli.us>
>Date: Sun, 10 Jan 2016 09:32:16 +0100
>
>> From: Ido Schimmel <idosch@mellanox.com>
>>
>> Dumping the FDB (invoked with a process context) or handling FDB
>> notifications (polled periodicly in delayed work) might each entail
>> multiple EMAD transcations due to the number of entries.
>>
>> While we only allow one EMAD transaction at a time, there is nothing
>> stopping the dump and notification processing sessions from
>> interleaving. However, this is forbidden by the hardware, so we need to
>> make sure only one of these sessions can run at a time.
>>
>> Solve this by adding a mutex ('fdb_lock'), as both kernel threads can
>> sleep while waiting for the response EMAD.
>>
>> Fixes: 56ade8fe3f ("mlxsw: spectrum: Add initial support for Spectrum ASIC")
>> Signed-off-by: Ido Schimmel <idosch@mellanox.com>
>> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
>
>Jiri, I noticed you submitted both a net and a net-next variant of
>this same fix. Please don't ever do that.
>
>it's easiest if I just apply the 'net' variant and handle the merge
>issues when I pull 'net' into 'net-next', so that how I'm going to
>handle this change.
Okay. I just wanted to help since the net-next patch differs. Thanks!
prev parent reply other threads:[~2016-01-11 8:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-10 8:32 [patch net] mlxsw: spectrum: Add FDB lock to prevent session interleaving Jiri Pirko
2016-01-11 5:21 ` David Miller
2016-01-11 8:41 ` Jiri Pirko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160111084135.GA2246@nanopsycho.orion \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=eladr@mellanox.com \
--cc=idosch@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=yotamg@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).