From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Jia-Ju Bai <baijiaju1990@163.com>
Cc: kvalo@codeaurora.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iwl4965: Fix a null pointer dereference in il_tx_queue_free and il_cmd_queue_free
Date: Mon, 11 Jan 2016 13:12:08 +0100 [thread overview]
Message-ID: <20160111121208.GD25015@redhat.com> (raw)
In-Reply-To: <1452167498-10823-1-git-send-email-baijiaju1990@163.com>
On Thu, Jan 07, 2016 at 07:51:38PM +0800, Jia-Ju Bai wrote:
> err:
> - for (i = 0; i < actual_slots; i++)
> + for (i = 0; i < actual_slots; i++) {
> kfree(txq->cmd[i]);
> + txq->cmd[i] = NULL;
I don't think we need this, otherwise patch looks good.
Stanislaw
next prev parent reply other threads:[~2016-01-11 12:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 11:51 [PATCH] iwl4965: Fix a null pointer dereference in il_tx_queue_free and il_cmd_queue_free Jia-Ju Bai
2016-01-11 12:12 ` Stanislaw Gruszka [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-01-10 2:19 Jia-Ju Bai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160111121208.GD25015@redhat.com \
--to=sgruszka@redhat.com \
--cc=baijiaju1990@163.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).