* [PATCH] iwl4965: Fix a memory leak in error handling code of __il4965_up @ 2016-01-07 12:17 Jia-Ju Bai 2016-01-11 12:13 ` Stanislaw Gruszka 0 siblings, 1 reply; 6+ messages in thread From: Jia-Ju Bai @ 2016-01-07 12:17 UTC (permalink / raw) To: sgruszka, kvalo; +Cc: linux-wireless, netdev, linux-kernel, Jia-Ju Bai When il4965_hw_nic_init in __il4965_up fails, the memory allocated by iwl4965_sta_alloc_lq in iwl4965_alloc_bcast_station is not freed. This patches adds il_dealloc_bcast_stations in the error handling code of __il4965_up to fix this problem. This patch has been tested in real device, and it actually fixes the bug. Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com> --- drivers/net/wireless/iwlegacy/4965-mac.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/iwlegacy/4965-mac.c b/drivers/net/wireless/iwlegacy/4965-mac.c index 6656215..fd7b5c7 100644 --- a/drivers/net/wireless/iwlegacy/4965-mac.c +++ b/drivers/net/wireless/iwlegacy/4965-mac.c @@ -5577,6 +5577,7 @@ __il4965_up(struct il_priv *il) ret = il4965_hw_nic_init(il); if (ret) { IL_ERR("Unable to init nic\n"); + il_dealloc_bcast_stations(il); return ret; } -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] iwl4965: Fix a memory leak in error handling code of __il4965_up 2016-01-07 12:17 [PATCH] iwl4965: Fix a memory leak in error handling code of __il4965_up Jia-Ju Bai @ 2016-01-11 12:13 ` Stanislaw Gruszka 0 siblings, 0 replies; 6+ messages in thread From: Stanislaw Gruszka @ 2016-01-11 12:13 UTC (permalink / raw) To: Jia-Ju Bai; +Cc: kvalo, linux-wireless, netdev, linux-kernel On Thu, Jan 07, 2016 at 08:17:39PM +0800, Jia-Ju Bai wrote: > When il4965_hw_nic_init in __il4965_up fails, the memory allocated by > iwl4965_sta_alloc_lq in iwl4965_alloc_bcast_station is not freed. > > This patches adds il_dealloc_bcast_stations in the error handling code of > __il4965_up to fix this problem. > > This patch has been tested in real device, and it actually fixes the bug. > > Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com> Acked-by: Stanislaw Gruszka <sgruszka@redhat.com> ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] iwl4965: Fix a memory leak in error handling code of __il4965_up
@ 2016-01-10 2:19 Jia-Ju Bai
[not found] ` <1452392363-3600-1-git-send-email-baijiaju1990-9Onoh4P/yGk@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Jia-Ju Bai @ 2016-01-10 2:19 UTC (permalink / raw)
To: sgruszka-H+wXaHxf7aLQT0dZR+AlfA, kvalo-sgV2jX0FEOL9JmXXK+q4OQ,
johannes.berg-ral2JQCrhuEAvxtiuMwx3w,
emmanuel.grumbach-ral2JQCrhuEAvxtiuMwx3w
Cc: ilw-VuQAYsv1563Yd54FQh9/CA, linuxwifi-ral2JQCrhuEAvxtiuMwx3w,
linux-wireless-u79uwXL29TY76Z2rM5mHXA,
netdev-u79uwXL29TY76Z2rM5mHXA, Jia-Ju Bai
When il4965_hw_nic_init in __il4965_up fails, the memory allocated by
iwl4965_sta_alloc_lq in iwl4965_alloc_bcast_station is not freed.
This patches adds il_dealloc_bcast_stations in the error handling code of
__il4965_up to fix this problem.
This patch has been tested in real device, and it actually fixes the bug.
Signed-off-by: Jia-Ju Bai <baijiaju1990-9Onoh4P/yGk@public.gmane.org>
---
drivers/net/wireless/iwlegacy/4965-mac.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/iwlegacy/4965-mac.c b/drivers/net/wireless/iwlegacy/4965-mac.c
index 6656215..fd7b5c7 100644
--- a/drivers/net/wireless/iwlegacy/4965-mac.c
+++ b/drivers/net/wireless/iwlegacy/4965-mac.c
@@ -5577,6 +5577,7 @@ __il4965_up(struct il_priv *il)
ret = il4965_hw_nic_init(il);
if (ret) {
IL_ERR("Unable to init nic\n");
+ il_dealloc_bcast_stations(il);
return ret;
}
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 6+ messages in thread[parent not found: <1452392363-3600-1-git-send-email-baijiaju1990-9Onoh4P/yGk@public.gmane.org>]
* Re: [PATCH] iwl4965: Fix a memory leak in error handling code of __il4965_up [not found] ` <1452392363-3600-1-git-send-email-baijiaju1990-9Onoh4P/yGk@public.gmane.org> @ 2016-01-11 12:16 ` Stanislaw Gruszka 2016-01-11 12:44 ` Kalle Valo 2016-01-11 13:41 ` Jia-Ju Bai 0 siblings, 2 replies; 6+ messages in thread From: Stanislaw Gruszka @ 2016-01-11 12:16 UTC (permalink / raw) To: Jia-Ju Bai Cc: kvalo-sgV2jX0FEOL9JmXXK+q4OQ, johannes.berg-ral2JQCrhuEAvxtiuMwx3w, emmanuel.grumbach-ral2JQCrhuEAvxtiuMwx3w, ilw-VuQAYsv1563Yd54FQh9/CA, linuxwifi-ral2JQCrhuEAvxtiuMwx3w, linux-wireless-u79uwXL29TY76Z2rM5mHXA, netdev-u79uwXL29TY76Z2rM5mHXA On Sun, Jan 10, 2016 at 10:19:23AM +0800, Jia-Ju Bai wrote: > diff --git a/drivers/net/wireless/iwlegacy/4965-mac.c b/drivers/net/wireless/iwlegacy/4965-mac.c > index 6656215..fd7b5c7 100644 > --- a/drivers/net/wireless/iwlegacy/4965-mac.c > +++ b/drivers/net/wireless/iwlegacy/4965-mac.c > @@ -5577,6 +5577,7 @@ __il4965_up(struct il_priv *il) > ret = il4965_hw_nic_init(il); > if (ret) { > IL_ERR("Unable to init nic\n"); > + il_dealloc_bcast_stations(il); > return ret; > } Please do not repost patches so frequent and if you repost the unchanged patch mark it so i.e. [PATCH repost]. Stanislaw -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] iwl4965: Fix a memory leak in error handling code of __il4965_up 2016-01-11 12:16 ` Stanislaw Gruszka @ 2016-01-11 12:44 ` Kalle Valo 2016-01-11 13:41 ` Jia-Ju Bai 1 sibling, 0 replies; 6+ messages in thread From: Kalle Valo @ 2016-01-11 12:44 UTC (permalink / raw) To: Stanislaw Gruszka Cc: Jia-Ju Bai, johannes.berg, emmanuel.grumbach, ilw, linuxwifi, linux-wireless, netdev Stanislaw Gruszka <sgruszka@redhat.com> writes: > On Sun, Jan 10, 2016 at 10:19:23AM +0800, Jia-Ju Bai wrote: >> diff --git a/drivers/net/wireless/iwlegacy/4965-mac.c b/drivers/net/wireless/iwlegacy/4965-mac.c >> index 6656215..fd7b5c7 100644 >> --- a/drivers/net/wireless/iwlegacy/4965-mac.c >> +++ b/drivers/net/wireless/iwlegacy/4965-mac.c >> @@ -5577,6 +5577,7 @@ __il4965_up(struct il_priv *il) >> ret = il4965_hw_nic_init(il); >> if (ret) { >> IL_ERR("Unable to init nic\n"); >> + il_dealloc_bcast_stations(il); >> return ret; >> } > > Please do not repost patches so frequent and if you repost > the unchanged patch mark it so i.e. [PATCH repost]. "repost" just confuses me and creates more work for me. Better to ping on the original patch and even better is to check patchwork which shows up-to-date status of wireless patches: https://patchwork.kernel.org/project/linux-wireless/list/ -- Kalle Valo ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] iwl4965: Fix a memory leak in error handling code of __il4965_up 2016-01-11 12:16 ` Stanislaw Gruszka 2016-01-11 12:44 ` Kalle Valo @ 2016-01-11 13:41 ` Jia-Ju Bai 1 sibling, 0 replies; 6+ messages in thread From: Jia-Ju Bai @ 2016-01-11 13:41 UTC (permalink / raw) To: Stanislaw Gruszka Cc: kvalo, johannes.berg, emmanuel.grumbach, ilw, linuxwifi, linux-wireless, netdev On 01/11/2016 08:16 PM, Stanislaw Gruszka wrote: > > Please do not repost patches so frequent and if you repost > the unchanged patch mark it so i.e. [PATCH repost]. > > Stanislaw Sorry for my reposting. Jia-Ju Bai ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-01-11 13:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-07 12:17 [PATCH] iwl4965: Fix a memory leak in error handling code of __il4965_up Jia-Ju Bai
2016-01-11 12:13 ` Stanislaw Gruszka
-- strict thread matches above, loose matches on Subject: below --
2016-01-10 2:19 Jia-Ju Bai
[not found] ` <1452392363-3600-1-git-send-email-baijiaju1990-9Onoh4P/yGk@public.gmane.org>
2016-01-11 12:16 ` Stanislaw Gruszka
2016-01-11 12:44 ` Kalle Valo
2016-01-11 13:41 ` Jia-Ju Bai
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).