From: Stanislaw Gruszka <sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Jia-Ju Bai <baijiaju1990-9Onoh4P/yGk@public.gmane.org>
Cc: kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
johannes.berg-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
emmanuel.grumbach-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
ilw-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
linuxwifi-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2] iwl4965: Fix a null pointer dereference in il_tx_queue_free and il_cmd_queue_free
Date: Mon, 11 Jan 2016 15:04:31 +0100 [thread overview]
Message-ID: <20160111140431.GB26139@redhat.com> (raw)
In-Reply-To: <1452519775-7049-1-git-send-email-baijiaju1990-9Onoh4P/yGk@public.gmane.org>
On Mon, Jan 11, 2016 at 09:42:54PM +0800, Jia-Ju Bai wrote:
> If "txq->cmd = kzalloc(...)" in il_tx_queue_init fails,
> "kfree(txq->cmd[i])" in il_tx_queue_free and il_cmd_queue_free
> in iwl4965_hw_txq_ctx_free will causes a null pointer dereference,
> because txq->cmd is NULL at that time.
>
> This patch fixes this problem by adding a if-check before kfree.
> To avoid double free in il_tx_queue_free and il_cmd_queue_free
> caused by the fixing, txq->meta and txq->cmd in error handling code
> of il_tx_queue_init are assigned null values.
> Otherwise, a double free will occur.
>
> This patch has been tested in real device, and it actually fixes the bug.
> Thanks Stanislaw for his suggestion.
>
> Signed-off-by: Jia-Ju Bai <baijiaju1990-9Onoh4P/yGk@public.gmane.org>
Acked-by: Stanislaw Gruszka <sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2016-01-11 14:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 13:42 [PATCH v2] iwl4965: Fix a null pointer dereference in il_tx_queue_free and il_cmd_queue_free Jia-Ju Bai
[not found] ` <1452519775-7049-1-git-send-email-baijiaju1990-9Onoh4P/yGk@public.gmane.org>
2016-01-11 14:04 ` Stanislaw Gruszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160111140431.GB26139@redhat.com \
--to=sgruszka-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=baijiaju1990-9Onoh4P/yGk@public.gmane.org \
--cc=emmanuel.grumbach-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=ilw-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=johannes.berg-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linuxwifi-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).