From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: ivo.g.dimitrov.75@gmail.com, courmisch@gmail.com,
noureddine@arista.com, pali.rohar@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
sre@kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH net] phonet: properly unshare skbs in phonet_rcv()
Date: Tue, 12 Jan 2016 15:47:18 -0500 (EST) [thread overview]
Message-ID: <20160112.154718.762462936767801736.davem@davemloft.net> (raw)
In-Reply-To: <1452617880.1223.21.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 12 Jan 2016 08:58:00 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> Ivaylo Dimitrov reported a regression caused by commit 7866a621043f
> ("dev: add per net_device packet type chains").
>
> skb->dev becomes NULL and we crash in __netif_receive_skb_core().
>
> Before above commit, different kind of bugs or corruptions could happen
> without major crash.
>
> But the root cause is that phonet_rcv() can queue skb without checking
> if skb is shared or not.
>
> Many thanks to Ivaylo Dimitrov for his help, diagnosis and tests.
>
> Reported-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
> Tested-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Remi Denis-Courmont <courmisch@gmail.com>
Applied and queued up for -stable, th anks Eric.
next prev parent reply other threads:[~2016-01-12 20:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 17:54 [OOPS] In __netif_receive_skb_core Ivaylo Dimitrov
2016-01-10 17:48 ` Ivaylo Dimitrov
2016-01-10 20:26 ` Eric Dumazet
2016-01-11 21:03 ` Ivaylo Dimitrov
2016-01-11 22:11 ` Salam Noureddine
2016-01-12 0:51 ` Ivaylo Dimitrov
2016-01-12 1:06 ` Eric Dumazet
2016-01-12 1:19 ` Salam Noureddine
2016-01-12 2:21 ` Eric Dumazet
2016-01-12 2:25 ` Eric Dumazet
2016-01-12 7:16 ` Ivaylo Dimitrov
2016-01-12 14:19 ` Eric Dumazet
2016-01-12 16:58 ` [PATCH net] phonet: properly unshare skbs in phonet_rcv() Eric Dumazet
2016-01-12 20:47 ` David Miller [this message]
2016-01-13 12:26 ` Rémi Denis-Courmont
2016-01-13 15:07 ` Eric Dumazet
2016-01-12 18:15 ` [OOPS] In __netif_receive_skb_core Salam Noureddine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160112.154718.762462936767801736.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=courmisch@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=noureddine@arista.com \
--cc=pali.rohar@gmail.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).