From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] net: bnxt: always return values from _bnxt_get_max_rings Date: Tue, 12 Jan 2016 16:44:48 -0500 (EST) Message-ID: <20160112.164448.2146712741894114084.davem@davemloft.net> References: <4309490.qRrvvx0n1Q@wuerfel> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, mchan@broadcom.com, huangjw@broadcom.com, linux-kernel@vger.kernel.org To: arnd@arndb.de Return-path: In-Reply-To: <4309490.qRrvvx0n1Q@wuerfel> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Arnd Bergmann Date: Tue, 12 Jan 2016 16:05:08 +0100 > Newly added code in the bnxt driver uses a couple of variables that > are never initialized when CONFIG_BNXT_SRIOV is not set, and gcc > correctly warns about that: > > In file included from include/linux/list.h:8:0, > from include/linux/module.h:9, > from drivers/net/ethernet/broadcom/bnxt/bnxt.c:10: > drivers/net/ethernet/broadcom/bnxt/bnxt.c: In function 'bnxt_get_max_rings': > include/linux/kernel.h:794:26: warning: 'cp' may be used uninitialized in this function [-Wmaybe-uninitialized] > include/linux/kernel.h:794:26: warning: 'tx' may be used uninitialized in this function [-Wmaybe-uninitialized] > drivers/net/ethernet/broadcom/bnxt/bnxt.c:5730:11: warning: 'rx' may be used uninitialized in this function [-Wmaybe-uninitialized] > drivers/net/ethernet/broadcom/bnxt/bnxt.c:5736:6: note: 'rx' was declared here > > This changes the condition so that we fall back to using the PF > data if VF is not available, and always initialize the variables > to something useful. > > Signed-off-by: Arnd Bergmann > Fixes: 6e6c5a57fbe1 ("bnxt_en: Modify bnxt_get_max_rings() to support shared or non shared rings.") Applied, thanks Arnd.