From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [PATCH 17/53] perf test: Improve bp_signal Date: Tue, 12 Jan 2016 14:17:42 +0000 Message-ID: <20160112141741.GH15737@arm.com> References: <1452520124-2073-1-git-send-email-wangnan0@huawei.com> <1452520124-2073-18-git-send-email-wangnan0@huawei.com> <20160111213729.GI18367@kernel.org> <20160112092129.GA2187@krava.brq.redhat.com> <20160112141123.GQ18367@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jiri Olsa , Wang Nan , linux-kernel@vger.kernel.org, pi3orama@163.com, lizefan@huawei.com, netdev@vger.kernel.org, Jiri Olsa To: Arnaldo Carvalho de Melo Return-path: Received: from foss.arm.com ([217.140.101.70]:34785 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752249AbcALORm (ORCPT ); Tue, 12 Jan 2016 09:17:42 -0500 Content-Disposition: inline In-Reply-To: <20160112141123.GQ18367@kernel.org> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Jan 12, 2016 at 11:11:23AM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Jan 12, 2016 at 10:21:29AM +0100, Jiri Olsa escreveu: > > On Mon, Jan 11, 2016 at 06:37:29PM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Mon, Jan 11, 2016 at 01:48:08PM +0000, Wang Nan escreveu: > > > > Will Deacon [1] has some question on patch [2]. This patch improves > > > > test__bp_signal so we can test: > > > > > > > > 1. A watchpoint and a breakpoint that fire on the same instruction > > > > 2. Nested signals > > > > > > > > Test result: > > > > > > > > On x86_64 and ARM64 (result are similar with patch [2] on ARM64): > > > > > > > > # ./perf test -v signal > > > > 17: Test breakpoint overflow signal handler : > > > > --- start --- > > > > test child forked, pid 10213 > > > > count1 1, count2 3, count3 2, overflow 3, overflows_2 3 > > > > test child finished with 0 > > > > ---- end ---- > > > > Test breakpoint overflow signal handler: Ok > > > > > > > > So at least 2 cases Will doubted are handled correctly. > > > > > > > > [1] http://lkml.kernel.org/g/20160104165535.GI1616@arm.com > > > > [2] http://lkml.kernel.org/g/1450921362-198371-1-git-send-email-wangnan0@huawei.com > > > > > > > > Signed-off-by: Wang Nan > > > > Cc: Will Deacon > > > > > > Will, are you ok with this one? Can I have an Acked-by or better, > > > Tested-by for the AARCH64 base? > > > > > > IIRC Jiri made some comment about this one? > > > > I thought I acked this one.. all comments were addresses, so: > > > > Acked-by: Jiri Olsa > > Ok, so, Will, any comments? Nack? Sorry, snowed under at the moment. I need to go back over the arch/arm64 patch, since I did have some concerns on that and the changes to the perf tool don't do a lot without the corresponding architecture update which I'm extremely nervous about. I'll revisit that patch once I've got through the more pressing changes in the queue. Will