From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: daniel@iogearbox.net, netdev@vger.kernel.org, ast@kernel.org,
rabin@rab.in, alexei.starovoitov@gmail.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv2] net: bpf: reject invalid shifts
Date: Wed, 13 Jan 2016 00:00:16 -0500 (EST) [thread overview]
Message-ID: <20160113.000016.2304166666171388740.davem@davemloft.net> (raw)
In-Reply-To: <1452658064.1223.58.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 12 Jan 2016 20:07:44 -0800
> On Tue, 2016-01-12 at 21:43 -0500, David Miller wrote:
>> From: Eric Dumazet <eric.dumazet@gmail.com>
>> Date: Tue, 12 Jan 2016 18:11:38 -0800
>>
>> > As I said, it is possible some guys never noticed their BPF program
>> > were 'broken' because this invalid shift was hidden in a dead code
>> > part.
>>
>> We should not hide bugs and unintended uses of operations with
>> undefined behavior.
>
> JUMP 2:
> SHR 45
> 2: RET 10
>
>
> was a valid program.
>
> But a dumb loader decided to know better.
I guess you are uninterested in knowing your programs contains such
garbage.
next prev parent reply other threads:[~2016-01-13 5:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-12 17:55 [PATCH] net: bpf: reject invalid shifts Rabin Vincent
2016-01-12 18:51 ` Alexei Starovoitov
2016-01-12 19:17 ` [PATCHv2] " Rabin Vincent
2016-01-12 19:26 ` Alexei Starovoitov
2016-01-12 19:35 ` Daniel Borkmann
2016-01-12 19:48 ` Eric Dumazet
2016-01-12 19:53 ` Alexei Starovoitov
2016-01-12 20:42 ` Daniel Borkmann
2016-01-12 20:46 ` Alexei Starovoitov
2016-01-12 23:28 ` Eric Dumazet
2016-01-12 23:47 ` Alexei Starovoitov
2016-01-12 23:59 ` Hannes Frederic Sowa
2016-01-13 0:17 ` Hannes Frederic Sowa
2016-01-13 0:19 ` Alexei Starovoitov
2016-01-13 0:42 ` Hannes Frederic Sowa
2016-01-13 2:11 ` Eric Dumazet
2016-01-13 2:24 ` Alexei Starovoitov
2016-01-13 2:45 ` David Miller
2016-01-13 2:43 ` David Miller
2016-01-13 4:07 ` Eric Dumazet
2016-01-13 5:00 ` David Miller [this message]
2016-01-13 4:27 ` Hannes Frederic Sowa
2016-01-12 22:34 ` Eric Dumazet
2016-01-12 20:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160113.000016.2304166666171388740.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=rabin@rab.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).