From: David Miller <davem@davemloft.net>
To: matti.vaittinen@nokia.com
Cc: johannes.berg@intel.com, jbenc@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
alexander.sverdlin@nokia.com, teppo.o.pennanen@nokia.com
Subject: Re: [PATCH v2 1/1] net: netlink: Fix multicast group storage allocation for families with more than one groups
Date: Wed, 13 Jan 2016 10:27:35 -0500 (EST) [thread overview]
Message-ID: <20160113.102735.1851782053420522112.davem@davemloft.net> (raw)
In-Reply-To: <20160113075400.GA12580@fi-ourus-dhcp00977.emea.nsn-net.net>
From: Matti Vaittinen <matti.vaittinen@nokia.com>
Date: Wed, 13 Jan 2016 09:54:12 +0200
> Hello again,
>
> Second version, Fixed the 'off by one' bug spotted by David.
>
> Br.
> Matti Vaittinen
>
> Multicast groups are stored in global buffer. Check for needed buffer size
> incorrectly compares buffer size to first id for family. This means that
> for families with more than one mcast id one may allocate too small buffer
> and end up writing rest of the groups to some unallocated memory. Fix the
> buffer size check to compare allocated space to last mcast id for the
> family.
>
> Tested on ARM using kernel 3.14
>
> Signed-off-by: Matti Vaittinen <matti.vaittinen@nokia.com>
I inadvertantly applied your original patch, so I'll just fix
the off-by-one error with a seperate commit.
Sorry for the confusion and thanks for fixing this.
prev parent reply other threads:[~2016-01-13 15:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 7:54 [PATCH v2 1/1] net: netlink: Fix multicast group storage allocation for families with more than one groups Matti Vaittinen
2016-01-13 15:27 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160113.102735.1851782053420522112.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.sverdlin@nokia.com \
--cc=jbenc@redhat.com \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matti.vaittinen@nokia.com \
--cc=netdev@vger.kernel.org \
--cc=teppo.o.pennanen@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).