From: David Miller <davem@davemloft.net>
To: tom@herbertland.com
Cc: haiyangz@microsoft.com, eric.dumazet@gmail.com,
gnomes@lxorguk.ukuu.org.uk, vkuznets@redhat.com,
netdev@vger.kernel.org, kys@microsoft.com,
devel@linuxdriverproject.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] hv_netvsc: don't make assumptions on struct flow_keys layout
Date: Thu, 14 Jan 2016 17:06:25 -0500 (EST) [thread overview]
Message-ID: <20160114.170625.332893838261533719.davem@davemloft.net> (raw)
In-Reply-To: <CALx6S349p_2XwFXM_T74PzSmJ6F9petkyX_5dY-PEp2O7Y9vfA@mail.gmail.com>
From: Tom Herbert <tom@herbertland.com>
Date: Thu, 14 Jan 2016 13:44:24 -0800
> The fact that we can negatively affect the output of Toeplitz so
> predictably is actually a liability and not a benefit. This sort of
> thing can be the basis of a DOS attack and is why we kicked out XOR
> hash in favor of Jenkins.
+1
Toeplitz should not be used for any software calculated flow hash
whatsoever.
next prev parent reply other threads:[~2016-01-14 22:06 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 9:33 [PATCH net-next] hv_netvsc: don't make assumptions on struct flow_keys layout Vitaly Kuznetsov
2016-01-07 12:52 ` Eric Dumazet
2016-01-07 13:28 ` Vitaly Kuznetsov
2016-01-08 1:02 ` John Fastabend
2016-01-08 3:49 ` KY Srinivasan
2016-01-08 6:16 ` John Fastabend
2016-01-08 18:01 ` KY Srinivasan
2016-01-08 21:07 ` Haiyang Zhang
2016-01-09 0:17 ` Tom Herbert
2016-01-10 22:25 ` David Miller
2016-01-13 23:10 ` Haiyang Zhang
2016-01-14 4:56 ` David Miller
2016-01-14 17:14 ` Tom Herbert
2016-01-14 17:53 ` One Thousand Gnomes
2016-01-14 18:24 ` Eric Dumazet
2016-01-14 18:35 ` Haiyang Zhang
2016-01-14 18:48 ` Tom Herbert
2016-01-14 19:15 ` Haiyang Zhang
2016-01-14 19:41 ` Tom Herbert
2016-01-14 20:23 ` Haiyang Zhang
2016-01-14 21:44 ` Tom Herbert
2016-01-14 22:06 ` David Miller [this message]
2016-01-14 22:08 ` Eric Dumazet
2016-01-14 22:29 ` Haiyang Zhang
2016-01-14 17:53 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160114.170625.332893838261533719.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=devel@linuxdriverproject.org \
--cc=eric.dumazet@gmail.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tom@herbertland.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).