* [PATCH] r8152 add Microsoft Dock IDs
@ 2016-01-13 17:06 René Rebe
2016-01-13 19:51 ` David Miller
0 siblings, 1 reply; 6+ messages in thread
From: René Rebe @ 2016-01-13 17:06 UTC (permalink / raw)
To: netdev; +Cc: nic_swsd
Hi there,
The Microsoft Surface Docks uses a R8152, too.
Signed-off-by: René Rebe <rene@exactcode.com>
--- linux-3.19/drivers/net/usb/r8152.c.orig 2015-02-09 02:54:22.000000000 +0000
+++ linux-3.19/drivers/net/usb/r8152.c 2015-02-15 15:52:52.924000000 +0000
@@ -462,6 +462,7 @@
/* Define these values to match your device */
#define VENDOR_ID_REALTEK 0x0bda
+#define VENDOR_ID_MICROSOFT 0x045e
#define VENDOR_ID_SAMSUNG 0x04e8
#define MCU_TYPE_PLA 0x0100
@@ -3932,6 +3933,8 @@
static struct usb_device_id rtl8152_table[] = {
{REALTEK_USB_DEVICE(VENDOR_ID_REALTEK, 0x8152)},
{REALTEK_USB_DEVICE(VENDOR_ID_REALTEK, 0x8153)},
+ {REALTEK_USB_DEVICE(VENDOR_ID_MICROSOFT, 0x07ab)},
+ {REALTEK_USB_DEVICE(VENDOR_ID_MICROSOFT, 0x07c6)},
{REALTEK_USB_DEVICE(VENDOR_ID_SAMSUNG, 0xa101)},
{}
};
--
ExactCODE GmbH, Lietzenburger Str. 42, DE-10789 Berlin
http://exactcode.com | http://exactscan.com | http://ocrkit.com | http://t2-project.org | http://rene.rebe.de
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] r8152 add Microsoft Dock IDs
2016-01-13 17:06 René Rebe
@ 2016-01-13 19:51 ` David Miller
2016-01-13 20:03 ` René Rebe
0 siblings, 1 reply; 6+ messages in thread
From: David Miller @ 2016-01-13 19:51 UTC (permalink / raw)
To: rene; +Cc: netdev, nic_swsd
From: René Rebe <rene@exactcode.com>
Date: Wed, 13 Jan 2016 18:06:36 +0100
> Hi there,
>
> The Microsoft Surface Docks uses a R8152, too.
>
> Signed-off-by: René Rebe <rene@exactcode.com>
Your patch was corrupted by your email client.
Please fix this, send a test patch to yourself, and please do not
resubmit the patch here until after you can successfully apply the
patch you receive in that test email.
Please also do not use attachments to solve this problem.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] r8152 add Microsoft Dock IDs
2016-01-13 19:51 ` David Miller
@ 2016-01-13 20:03 ` René Rebe
2016-01-13 20:49 ` David Miller
0 siblings, 1 reply; 6+ messages in thread
From: René Rebe @ 2016-01-13 20:03 UTC (permalink / raw)
To: David Miller; +Cc: netdev, nic_swsd
Hi David,
On Jan 13, 2016, at 20:51, David Miller <davem@davemloft.net> wrote:
> Your patch was corrupted by your email client.
Ieek, guess that’s what I get from not using Mew on my Ultra5 anymore :-/
Crossing fingers it works this time, ...
The Microsoft Surface Docks uses a R8152, too.
Signed-off-by: René Rebe <rene@exactcode.com>
--- linux-3.19/drivers/net/usb/r8152.c.orig 2015-02-09 02:54:22.000000000 +0000
+++ linux-3.19/drivers/net/usb/r8152.c 2015-02-15 15:52:52.924000000 +0000
@@ -462,6 +462,7 @@
/* Define these values to match your device */
#define VENDOR_ID_REALTEK 0x0bda
+#define VENDOR_ID_MICROSOFT 0x045e
#define VENDOR_ID_SAMSUNG 0x04e8
#define MCU_TYPE_PLA 0x0100
@@ -3932,6 +3933,8 @@
static struct usb_device_id rtl8152_table[] = {
{REALTEK_USB_DEVICE(VENDOR_ID_REALTEK, 0x8152)},
{REALTEK_USB_DEVICE(VENDOR_ID_REALTEK, 0x8153)},
+ {REALTEK_USB_DEVICE(VENDOR_ID_MICROSOFT, 0x07ab)},
+ {REALTEK_USB_DEVICE(VENDOR_ID_MICROSOFT, 0x07c6)},
{REALTEK_USB_DEVICE(VENDOR_ID_SAMSUNG, 0xa101)},
{}
};
--
ExactCODE GmbH, Lietzenburger Str. 42, DE-10789 Berlin
http://exactcode.com | http://exactscan.com | http://ocrkit.com | http://t2-project.org | http://rene.rebe.de
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] r8152 add Microsoft Dock IDs
2016-01-13 20:03 ` René Rebe
@ 2016-01-13 20:49 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2016-01-13 20:49 UTC (permalink / raw)
To: rene; +Cc: netdev, nic_swsd
From: René Rebe <rene@exactcode.com>
Date: Wed, 13 Jan 2016 21:03:30 +0100
> Hi David,
>
> On Jan 13, 2016, at 20:51, David Miller <davem@davemloft.net> wrote:
>
>> Your patch was corrupted by your email client.
>
> Ieek, guess that’s what I get from not using Mew on my Ultra5 anymore :-/
> Crossing fingers it works this time, ...
>
> The Microsoft Surface Docks uses a R8152, too.
>
> Signed-off-by: René Rebe <rene@exactcode.com>
Sorry, this does not apply to my net tree at all.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] r8152 add Microsoft Dock IDs
@ 2016-01-14 17:46 Rene Rebe
2016-01-14 18:16 ` Andrew Lunn
0 siblings, 1 reply; 6+ messages in thread
From: Rene Rebe @ 2016-01-14 17:46 UTC (permalink / raw)
To: netdev; +Cc: davem
Hi David,
(my appologies for wasting your time with this noise)
rebased against your netdev git, and sent with Mew:
The Microsoft Surface Docks uses a R8152, too.
Signed-off-by: René Rebe <rene@exactcode.com>
--- linux-git/drivers/net/usb/r8152.c.orig 2016-01-14 15:17:54.786662456 +0100
+++ linux-git/drivers/net/usb/r8152.c 2016-01-14 15:17:21.050661823 +0100
@@ -504,6 +504,7 @@
/* Define these values to match your device */
#define VENDOR_ID_REALTEK 0x0bda
+#define VENDOR_ID_MICROSOFT 0x045e
#define VENDOR_ID_SAMSUNG 0x04e8
#define VENDOR_ID_LENOVO 0x17ef
#define VENDOR_ID_NVIDIA 0x0955
@@ -4294,6 +4295,8 @@
static struct usb_device_id rtl8152_table[] = {
{REALTEK_USB_DEVICE(VENDOR_ID_REALTEK, 0x8152)},
{REALTEK_USB_DEVICE(VENDOR_ID_REALTEK, 0x8153)},
+ {REALTEK_USB_DEVICE(VENDOR_ID_MICROSOFT, 0x07ab)},
+ {REALTEK_USB_DEVICE(VENDOR_ID_MICROSOFT, 0x07c6)},
{REALTEK_USB_DEVICE(VENDOR_ID_SAMSUNG, 0xa101)},
{REALTEK_USB_DEVICE(VENDOR_ID_LENOVO, 0x7205)},
{REALTEK_USB_DEVICE(VENDOR_ID_LENOVO, 0x304f)},
--
René Rebe, ExactCODE GmbH, Lietzenburger Str. 42, DE-10117 Berlin
http://exactcode.com | http://t2-project.org | http://rene.rebe.de
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] r8152 add Microsoft Dock IDs
2016-01-14 17:46 [PATCH] r8152 add Microsoft Dock IDs Rene Rebe
@ 2016-01-14 18:16 ` Andrew Lunn
0 siblings, 0 replies; 6+ messages in thread
From: Andrew Lunn @ 2016-01-14 18:16 UTC (permalink / raw)
To: Rene Rebe; +Cc: netdev, davem
On Thu, Jan 14, 2016 at 06:46:26PM +0100, Rene Rebe wrote:
> Hi David,
> (my appologies for wasting your time with this noise)
>
> rebased against your netdev git, and sent with Mew:
Hi Rene
So, slowly getting better. However, go read
Documentation/SubmittingPatches
Read the bit about the "---" marker.
netdev also has a few additional rules, which are not documented in
SubmittingPatches.
In the subject line, you should include which tree this patch is
supposed to be applied to. In this case, it is net-next. So you
subject line should be
Subject: [PATCH net-next] r8152 add Microsoft Dock IDs
and obviously, your patch needs to cleanly apply to net-next, not some
other random tree.
The other rule which is relevant at the moment, is that net-next is
closed, because the merge window is open. So please wait about 12 days
for net-next to reopen. David will probably send an email saying he is
ready to accept new patches.
Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-01-14 18:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-14 17:46 [PATCH] r8152 add Microsoft Dock IDs Rene Rebe
2016-01-14 18:16 ` Andrew Lunn
-- strict thread matches above, loose matches on Subject: below --
2016-01-13 17:06 René Rebe
2016-01-13 19:51 ` David Miller
2016-01-13 20:03 ` René Rebe
2016-01-13 20:49 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).