netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: fw@strlen.de
Cc: koct9i@gmail.com, netdev@vger.kernel.org, dev@openvswitch.org,
	cascardo@redhat.com, edumazet@google.com,
	linux-kernel@vger.kernel.org, pshelar@nicira.com,
	xiyou.wangcong@gmail.com
Subject: Re: [PATCH v2] net: preserve IP control block during GSO segmentation
Date: Fri, 15 Jan 2016 14:35:53 -0500 (EST)	[thread overview]
Message-ID: <20160115.143553.1070533798353652921.davem@davemloft.net> (raw)
In-Reply-To: <20160113233628.GA10507@breakpoint.cc>

From: Florian Westphal <fw@strlen.de>
Date: Thu, 14 Jan 2016 00:36:28 +0100

> David Miller <davem@davemloft.net> wrote:
>> From: Konstantin Khlebnikov <koct9i@gmail.com>
>> Date: Fri, 08 Jan 2016 15:21:46 +0300
>> 
>> > Skb_gso_segment() uses skb control block during segmentation.
>> > This patch adds 32-bytes room for previous control block which
>> > will be copied into all resulting segments.
>> > 
>> > This patch fixes kernel crash during fragmenting forwarded packets.
>> > Fragmentation requires valid IP CB in skb for clearing ip options.
>> > Also patch removes custom save/restore in ovs code, now it's redundant.
>> > 
>> > Signed-off-by: Konstantin Khlebnikov <koct9i@gmail.com>
>> > Link: http://lkml.kernel.org/r/CALYGNiP-0MZ-FExV2HutTvE9U-QQtkKSoE--KN=JQE5STYsjAA@mail.gmail.com
>> 
>> If this works I definitely prefer this approach to the other patch
>> where the CB is copied back and forth.
> 
> I quite frankly don't care and just like you to apply one or the other;
> use coin toss if needed :-}

So I am going to apply this patch from Konstantin and queued it up for -stable.

Thanks.

      parent reply	other threads:[~2016-01-15 19:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-08 12:21 [PATCH v2] net: preserve IP control block during GSO segmentation Konstantin Khlebnikov
2016-01-13 20:51 ` David Miller
     [not found]   ` <20160113.155112.119405358547782630.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2016-01-13 23:36     ` Florian Westphal
     [not found]       ` <20160113233628.GA10507-E0PNVn5OA6ohrxcnuTQ+TQ@public.gmane.org>
2016-01-14 23:22         ` Hannes Frederic Sowa
2016-01-15 19:35       ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160115.143553.1070533798353652921.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=cascardo@redhat.com \
    --cc=dev@openvswitch.org \
    --cc=edumazet@google.com \
    --cc=fw@strlen.de \
    --cc=koct9i@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pshelar@nicira.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).