From: David Miller <davem@davemloft.net>
To: sjoerd.simons@collabora.co.uk
Cc: netdev@vger.kernel.org, andrew@lunn.ch,
linux-kernel@vger.kernel.org, f.fainelli@gmail.com
Subject: Re: [PATCH] net: phy: turn carrier off on phy attach
Date: Fri, 15 Jan 2016 14:50:03 -0500 (EST) [thread overview]
Message-ID: <20160115.145003.183831730517733849.davem@davemloft.net> (raw)
In-Reply-To: <1452805038-27178-1-git-send-email-sjoerd.simons@collabora.co.uk>
From: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Date: Thu, 14 Jan 2016 21:57:18 +0100
> The operstate of a networking device initially IF_OPER_UNKNOWN aka
> "unknown", updated on carrier state changes (with carrier state being on
> by default). This means it will stay unknown unless the carrier state
> goes to off at some point, which is not the case if the phy is already
> up/connected at startup.
>
> Explicitly turn off the carrier on phy attach, leaving the phy state
> machine to turn the carrier on when it has done the initial negotiation.
>
> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Applied, thank you.
next prev parent reply other threads:[~2016-01-15 19:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-14 20:57 [PATCH] net: phy: turn carrier off on phy attach Sjoerd Simons
2016-01-15 19:50 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-01-09 18:44 Sjoerd Simons
2016-01-11 22:17 ` David Miller
2016-01-12 0:57 ` Andrew Lunn
2016-01-13 1:31 ` Florian Fainelli
2016-01-14 20:22 ` Sjoerd Simons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160115.145003.183831730517733849.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sjoerd.simons@collabora.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).