From: David Miller <davem@davemloft.net>
To: t.remmet@phytec.de
Cc: netdev@vger.kernel.org, f.fainelli@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: phy: smsc: Fix disabling energy detect mode
Date: Fri, 15 Jan 2016 14:55:02 -0500 (EST) [thread overview]
Message-ID: <20160115.145502.1019508793273660216.davem@davemloft.net> (raw)
In-Reply-To: <1452849633-26877-1-git-send-email-t.remmet@phytec.de>
From: Teresa Remmet <t.remmet@phytec.de>
Date: Fri, 15 Jan 2016 10:20:33 +0100
> @@ -110,10 +105,11 @@ static int lan911x_config_init(struct phy_device *phydev)
> */
> static int lan87xx_read_status(struct phy_device *phydev)
> {
> + bool *energy_enable = phydev->priv;
> int err = genphy_read_status(phydev);
> int i;
Please order local variable declarations from longest to shortest line.
> +static int smsc_phy_probe(struct phy_device *phydev)
> +{
> + struct device *dev = &phydev->mdio.dev;
> + bool *energy_enable;
> + int __maybe_unused len;
> + struct device_node *of_node __maybe_unused = dev->of_node;
Likewise.
next prev parent reply other threads:[~2016-01-15 19:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 9:20 [PATCH] net: phy: smsc: Fix disabling energy detect mode Teresa Remmet
2016-01-15 19:55 ` David Miller [this message]
2016-01-16 17:11 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160115.145502.1019508793273660216.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=t.remmet@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).