From: David Miller <davem@davemloft.net>
To: david.vrabel@citrix.com
Cc: netdev@vger.kernel.org, xen-devel@lists.xenproject.org,
konrad.wilk@oracle.com, boris.ostrovsky@oracle.com,
malcolm.crossley@citrix.com
Subject: Re: [PATCHv1 net] xen-netfront: request Tx response events more often
Date: Fri, 15 Jan 2016 14:58:46 -0500 (EST) [thread overview]
Message-ID: <20160115.145846.2281196804935039066.davem@davemloft.net> (raw)
In-Reply-To: <1452859002-18543-1-git-send-email-david.vrabel@citrix.com>
From: David Vrabel <david.vrabel@citrix.com>
Date: Fri, 15 Jan 2016 11:56:42 +0000
> @@ -364,6 +364,7 @@ static void xennet_tx_buf_gc(struct netfront_queue *queue)
> RING_IDX cons, prod;
> unsigned short id;
> struct sk_buff *skb;
> + int more_to_do;
I hate to be difficult, but could you please use 'bool' for this variable?
Thanks!
prev parent reply other threads:[~2016-01-15 19:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 11:56 [PATCHv1 net] xen-netfront: request Tx response events more often David Vrabel
2016-01-15 19:58 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160115.145846.2281196804935039066.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=malcolm.crossley@citrix.com \
--cc=netdev@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).