From: David Miller <davem@davemloft.net>
To: zlim.lnx@gmail.com
Cc: will.deacon@arm.com, ast@kernel.org, catalin.marinas@arm.com,
rabin@rab.in, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] arm64: insn: remove BUG_ON from codegen
Date: Sun, 17 Jan 2016 19:15:40 -0500 (EST) [thread overview]
Message-ID: <20160117.191540.973637884089764401.davem@davemloft.net> (raw)
In-Reply-To: <1452756802-16511-1-git-send-email-zlim.lnx@gmail.com>
From: Zi Shen Lim <zlim.lnx@gmail.com>
Date: Wed, 13 Jan 2016 23:33:21 -0800
> During code generation, we used to BUG_ON unknown/unsupported encoding
> or invalid parameters.
>
> Instead, now we report these as errors and simply return the
> instruction AARCH64_BREAK_FAULT. Users of these codegen helpers should
> check for and handle this failure condition as appropriate.
>
> Otherwise, unhandled codegen failure will result in trapping at
> run-time due to AARCH64_BREAK_FAULT, which is arguably better than a
> BUG_ON.
>
> Signed-off-by: Zi Shen Lim <zlim.lnx@gmail.com>
Applied.
next prev parent reply other threads:[~2016-01-18 0:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-14 7:33 [PATCH 1/2] arm64: insn: remove BUG_ON from codegen Zi Shen Lim
2016-01-14 7:33 ` [PATCH 2/2] arm64: bpf: add extra pass to handle faulty codegen Zi Shen Lim
2016-01-15 5:09 ` Alexei Starovoitov
2016-01-18 0:15 ` David Miller
2016-01-15 17:08 ` [PATCH 1/2] arm64: insn: remove BUG_ON from codegen Will Deacon
2016-01-18 0:15 ` David Miller
2016-01-18 0:15 ` David Miller [this message]
2016-03-15 4:28 ` 平松雅巳 / HIRAMATU，MASAMI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160117.191540.973637884089764401.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ast@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=rabin@rab.in \
--cc=will.deacon@arm.com \
--cc=zlim.lnx@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).