From: David Miller <davem@davemloft.net>
To: hannes@stressinduktion.org
Cc: pshelar@ovn.org, netdev@vger.kernel.org,
simon.horman@netronome.com, eric.dumazet@gmail.com
Subject: Re: [PATCH net v4] ovs: limit ovs recursions in ovs_execute_actions to not corrupt stack
Date: Mon, 18 Jan 2016 11:50:30 -0500 (EST) [thread overview]
Message-ID: <20160118.115030.221096335100780663.davem@davemloft.net> (raw)
In-Reply-To: <569CCAAC.6060906@stressinduktion.org>
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
Date: Mon, 18 Jan 2016 12:21:16 +0100
> I don't think that -rt kernels are important for openvswitch right
> now, so this is just a safe guard.
Hannes, whilst I don't want to explicitly make things harder for the -rt
folks, I don't think it's appropriate to put unnecessary preemtption
disables into the main kernel like this.
Someone reading the code as-is will say this is superfluous and (correctly)
submit a patch to remove the preemption disables.
Please remove this from your patch, someone can deal with this in the
-rt kernel as needed.
next prev parent reply other threads:[~2016-01-18 16:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 16:51 [PATCH net v4] ovs: limit ovs recursions in ovs_execute_actions to not corrupt stack Hannes Frederic Sowa
2016-01-16 17:04 ` pravin shelar
2016-01-18 0:26 ` David Miller
2016-01-18 11:21 ` Hannes Frederic Sowa
2016-01-18 16:50 ` David Miller [this message]
2016-01-18 16:58 ` Hannes Frederic Sowa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160118.115030.221096335100780663.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
--cc=simon.horman@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).