From: David Miller <davem@davemloft.net>
To: idosch@mellanox.com
Cc: netdev@vger.kernel.org, jiri@mellanox.com, eladr@mellanox.com,
yotamg@mellanox.com, ogerlitz@mellanox.com
Subject: Re: [PATCH net] team: Replace rcu_read_lock with a mutex in team_vlan_rx_kill_vid
Date: Mon, 18 Jan 2016 11:55:38 -0500 (EST) [thread overview]
Message-ID: <20160118.115538.1753600494506800913.davem@davemloft.net> (raw)
In-Reply-To: <1453131022-23818-1-git-send-email-idosch@mellanox.com>
From: Ido Schimmel <idosch@mellanox.com>
Date: Mon, 18 Jan 2016 17:30:22 +0200
> We can't be within an RCU read-side critical section when deleting
> VLANs, as underlying drivers might sleep during the hardware operation.
> Therefore, replace the RCU critical section with a mutex. This is
> consistent with team_vlan_rx_add_vid.
>
> Fixes: 3d249d4ca7d0 ("net: introduce ethernet teaming device")
> Acked-by: Jiri Pirko <jiri@mellanox.com>
> Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2016-01-18 16:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-18 15:30 [PATCH net] team: Replace rcu_read_lock with a mutex in team_vlan_rx_kill_vid Ido Schimmel
2016-01-18 16:55 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160118.115538.1753600494506800913.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eladr@mellanox.com \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=yotamg@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).