[PATCH net 0/1] af_iucv: Validate socket address length in iucv_sock_bind()

[PATCH net 0/1] af_iucv: Validate socket address length in iucv_sock_bind()

[Ursula Braun]

From: Ursula Braun <ursula.braun@de.ibm.com>

this patch fixes a problem reported by Dmitry Vyukov in december. It is built
and intended for the next-tree.

Thanks, Ursula

Ursula Braun (1):
  af_iucv: Validate socket address length in iucv_sock_bind()

 net/iucv/af_iucv.c | 3 +++
 1 file changed, 3 insertions(+)

-- 
2.3.9

[PATCH net 1/1] af_iucv: Validate socket address length in iucv_sock_bind()

[Ursula Braun]

From: Ursula Braun <ursula.braun@de.ibm.com>

Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com>
Reported-by: Dmitry Vyukov <dvyukov@google.com>
Reviewed-by: Evgeny Cherkashin <Eugene.Crosser@ru.ibm.com>
---
 net/iucv/af_iucv.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/net/iucv/af_iucv.c b/net/iucv/af_iucv.c
index ef50a94..fc3598a 100644
--- a/net/iucv/af_iucv.c
+++ b/net/iucv/af_iucv.c
@@ -708,6 +708,9 @@ static int iucv_sock_bind(struct socket *sock, struct sockaddr *addr,
 	if (!addr || addr->sa_family != AF_IUCV)
 		return -EINVAL;
 
+	if (addr_len < sizeof(struct sockaddr_iucv))
+		return -EINVAL;
+
 	lock_sock(sk);
 	if (sk->sk_state != IUCV_OPEN) {
 		err = -EBADFD;
-- 
2.3.9

Re: [PATCH net 0/1] af_iucv: Validate socket address length in iucv_sock_bind()

[David Miller]

From: Ursula Braun <ubraun@linux.vnet.ibm.com>
Date: Tue, 19 Jan 2016 10:41:32 +0100

> this patch fixes a problem reported by Dmitry Vyukov in december. It is built
> and intended for the next-tree.

A bug fix is not appropriate for the next tree.

All bug fixes should target 'net'.  You even contacted me privately
asking me to queue this up for -stable.  Submitting something for
net-next and wanting a -stable backport is doubly inappropriate.

Things don't go to -stable unless it's in Linus's tree.  'net' is
for bug fixes, 'net-next' (closed right now) is for new features,
cleanups, and fixes to code only present in 'net-next'.

Anyways I applied this to 'net' and queued it up for -stable.