From: David Miller <davem@davemloft.net>
To: julia.lawall@lip6.fr
Cc: shuahkhan@gmail.com, bh74.an@samsung.com, ks.giri@samsung.com,
vipul.pandya@samsung.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, shuahkh@osg.samsung.com
Subject: Re: question about samsung/sxgbe/sxgbe_xpcs.c
Date: Tue, 19 Jan 2016 14:36:28 -0500 (EST) [thread overview]
Message-ID: <20160119.143628.432983847877790677.davem@davemloft.net> (raw)
In-Reply-To: <alpine.DEB.2.10.1601191918470.2531@hadrien>
From: Julia Lawall <julia.lawall@lip6.fr>
Date: Tue, 19 Jan 2016 19:54:20 +0100 (CET)
> On Tue, 19 Jan 2016, Shuah Khan wrote:
>
>> 2016-01-19 9:26 GMT-07:00 Julia Lawall <julia.lawall@lip6.fr>:
>> > Hello,
>> >
>> > I was windering what is the purpose of the file
>> > drivers/net/ethernet/samsung/sxgbe/sxgbe_xpcs.c
>>
>> From git log and comments, it appears this driver is for
>> Samsung SoCs.
>>
>> >
>> > I can't find anything that refers to it, and if I remove it from the
>> > makefile:
>> >
>> > @@ -1,4 +1,4 @@
>> > obj-$(CONFIG_SXGBE_ETH) += samsung-sxgbe.o
>> > samsung-sxgbe-objs:= sxgbe_platform.o sxgbe_main.o sxgbe_desc.o \
>> > sxgbe_dma.o sxgbe_core.o sxgbe_mtl.o sxgbe_mdio.o \
>> > - sxgbe_ethtool.o sxgbe_xpcs.o $(samsung-sxgbe-y)
>> > + sxgbe_ethtool.o $(samsung-sxgbe-y)
>> >
>> > and then make clean and recompile, I see no bad effect.
>> >
>>
>> What is the motivation for the experiment to remove it?
>> This file probably gets used only on Samsung SoCs.
>
> I just wondered. I was looking at dependencies between networking files.
> This one stands out because nothing is dependenton it, even the files it
> is compiled with, and it doesn't contain the usual functions,
> register_netdev, etc.
Even with that explanation, this is a bogus situation.
There are no in-tree callers of this code. It should be removed until there
are in-tree users.
Nobody can figure out if the interface for this is done properly without seeing
the call sites and how they work. It is therefore impossible to review this
code and judge it's design.
If someone doesn't send me a removal patch, I will remove this code myself.
next prev parent reply other threads:[~2016-01-19 19:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 16:26 question about samsung/sxgbe/sxgbe_xpcs.c Julia Lawall
2016-01-19 18:18 ` Shuah Khan
2016-01-19 18:54 ` Julia Lawall
2016-01-19 19:36 ` David Miller [this message]
2016-01-21 5:10 ` Jεan Sacren
2016-01-21 14:04 ` Shuah Khan
2016-01-21 19:09 ` David Miller
2016-01-21 18:45 ` David Miller
2016-01-21 19:32 ` Jεan Sacren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160119.143628.432983847877790677.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bh74.an@samsung.com \
--cc=julia.lawall@lip6.fr \
--cc=ks.giri@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shuahkh@osg.samsung.com \
--cc=shuahkhan@gmail.com \
--cc=vipul.pandya@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).