* question about samsung/sxgbe/sxgbe_xpcs.c
@ 2016-01-19 16:26 Julia Lawall
2016-01-19 18:18 ` Shuah Khan
0 siblings, 1 reply; 9+ messages in thread
From: Julia Lawall @ 2016-01-19 16:26 UTC (permalink / raw)
To: bh74.an, ks.giri, vipul.pandya, netdev, linux-kernel
Hello,
I was windering what is the purpose of the file
drivers/net/ethernet/samsung/sxgbe/sxgbe_xpcs.c
I can't find anything that refers to it, and if I remove it from the
makefile:
@@ -1,4 +1,4 @@
obj-$(CONFIG_SXGBE_ETH) += samsung-sxgbe.o
samsung-sxgbe-objs:= sxgbe_platform.o sxgbe_main.o sxgbe_desc.o \
sxgbe_dma.o sxgbe_core.o sxgbe_mtl.o sxgbe_mdio.o \
- sxgbe_ethtool.o sxgbe_xpcs.o $(samsung-sxgbe-y)
+ sxgbe_ethtool.o $(samsung-sxgbe-y)
and then make clean and recompile, I see no bad effect.
thanks,
julia
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: question about samsung/sxgbe/sxgbe_xpcs.c
2016-01-19 16:26 question about samsung/sxgbe/sxgbe_xpcs.c Julia Lawall
@ 2016-01-19 18:18 ` Shuah Khan
2016-01-19 18:54 ` Julia Lawall
0 siblings, 1 reply; 9+ messages in thread
From: Shuah Khan @ 2016-01-19 18:18 UTC (permalink / raw)
To: Julia Lawall; +Cc: bh74.an, ks.giri, vipul.pandya, netdev, LKML, shuahkh
2016-01-19 9:26 GMT-07:00 Julia Lawall <julia.lawall@lip6.fr>:
> Hello,
>
> I was windering what is the purpose of the file
> drivers/net/ethernet/samsung/sxgbe/sxgbe_xpcs.c
>From git log and comments, it appears this driver is for
Samsung SoCs.
>
> I can't find anything that refers to it, and if I remove it from the
> makefile:
>
> @@ -1,4 +1,4 @@
> obj-$(CONFIG_SXGBE_ETH) += samsung-sxgbe.o
> samsung-sxgbe-objs:= sxgbe_platform.o sxgbe_main.o sxgbe_desc.o \
> sxgbe_dma.o sxgbe_core.o sxgbe_mtl.o sxgbe_mdio.o \
> - sxgbe_ethtool.o sxgbe_xpcs.o $(samsung-sxgbe-y)
> + sxgbe_ethtool.o $(samsung-sxgbe-y)
>
> and then make clean and recompile, I see no bad effect.
>
What is the motivation for the experiment to remove it?
This file probably gets used only on Samsung SoCs.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: question about samsung/sxgbe/sxgbe_xpcs.c
2016-01-19 18:18 ` Shuah Khan
@ 2016-01-19 18:54 ` Julia Lawall
2016-01-19 19:36 ` David Miller
0 siblings, 1 reply; 9+ messages in thread
From: Julia Lawall @ 2016-01-19 18:54 UTC (permalink / raw)
To: Shuah Khan
Cc: Julia Lawall, bh74.an, ks.giri, vipul.pandya, netdev, LKML,
shuahkh
On Tue, 19 Jan 2016, Shuah Khan wrote:
> 2016-01-19 9:26 GMT-07:00 Julia Lawall <julia.lawall@lip6.fr>:
> > Hello,
> >
> > I was windering what is the purpose of the file
> > drivers/net/ethernet/samsung/sxgbe/sxgbe_xpcs.c
>
> From git log and comments, it appears this driver is for
> Samsung SoCs.
>
> >
> > I can't find anything that refers to it, and if I remove it from the
> > makefile:
> >
> > @@ -1,4 +1,4 @@
> > obj-$(CONFIG_SXGBE_ETH) += samsung-sxgbe.o
> > samsung-sxgbe-objs:= sxgbe_platform.o sxgbe_main.o sxgbe_desc.o \
> > sxgbe_dma.o sxgbe_core.o sxgbe_mtl.o sxgbe_mdio.o \
> > - sxgbe_ethtool.o sxgbe_xpcs.o $(samsung-sxgbe-y)
> > + sxgbe_ethtool.o $(samsung-sxgbe-y)
> >
> > and then make clean and recompile, I see no bad effect.
> >
>
> What is the motivation for the experiment to remove it?
> This file probably gets used only on Samsung SoCs.
I just wondered. I was looking at dependencies between networking files.
This one stands out because nothing is dependenton it, even the files it
is compiled with, and it doesn't contain the usual functions,
register_netdev, etc.
Thanks for the explanation.
julia
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: question about samsung/sxgbe/sxgbe_xpcs.c
2016-01-19 18:54 ` Julia Lawall
@ 2016-01-19 19:36 ` David Miller
2016-01-21 5:10 ` Jεan Sacren
0 siblings, 1 reply; 9+ messages in thread
From: David Miller @ 2016-01-19 19:36 UTC (permalink / raw)
To: julia.lawall
Cc: shuahkhan, bh74.an, ks.giri, vipul.pandya, netdev, linux-kernel,
shuahkh
From: Julia Lawall <julia.lawall@lip6.fr>
Date: Tue, 19 Jan 2016 19:54:20 +0100 (CET)
> On Tue, 19 Jan 2016, Shuah Khan wrote:
>
>> 2016-01-19 9:26 GMT-07:00 Julia Lawall <julia.lawall@lip6.fr>:
>> > Hello,
>> >
>> > I was windering what is the purpose of the file
>> > drivers/net/ethernet/samsung/sxgbe/sxgbe_xpcs.c
>>
>> From git log and comments, it appears this driver is for
>> Samsung SoCs.
>>
>> >
>> > I can't find anything that refers to it, and if I remove it from the
>> > makefile:
>> >
>> > @@ -1,4 +1,4 @@
>> > obj-$(CONFIG_SXGBE_ETH) += samsung-sxgbe.o
>> > samsung-sxgbe-objs:= sxgbe_platform.o sxgbe_main.o sxgbe_desc.o \
>> > sxgbe_dma.o sxgbe_core.o sxgbe_mtl.o sxgbe_mdio.o \
>> > - sxgbe_ethtool.o sxgbe_xpcs.o $(samsung-sxgbe-y)
>> > + sxgbe_ethtool.o $(samsung-sxgbe-y)
>> >
>> > and then make clean and recompile, I see no bad effect.
>> >
>>
>> What is the motivation for the experiment to remove it?
>> This file probably gets used only on Samsung SoCs.
>
> I just wondered. I was looking at dependencies between networking files.
> This one stands out because nothing is dependenton it, even the files it
> is compiled with, and it doesn't contain the usual functions,
> register_netdev, etc.
Even with that explanation, this is a bogus situation.
There are no in-tree callers of this code. It should be removed until there
are in-tree users.
Nobody can figure out if the interface for this is done properly without seeing
the call sites and how they work. It is therefore impossible to review this
code and judge it's design.
If someone doesn't send me a removal patch, I will remove this code myself.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: question about samsung/sxgbe/sxgbe_xpcs.c
2016-01-19 19:36 ` David Miller
@ 2016-01-21 5:10 ` Jεan Sacren
2016-01-21 14:04 ` Shuah Khan
2016-01-21 18:45 ` David Miller
0 siblings, 2 replies; 9+ messages in thread
From: Jεan Sacren @ 2016-01-21 5:10 UTC (permalink / raw)
To: David Miller
Cc: julia.lawall, shuahkhan, bh74.an, ks.giri, vipul.pandya, netdev,
linux-kernel, shuahkh
From: David Miller <davem@davemloft.net>
Date: Tue, 19 Jan 2016 14:36:28 -0500
>
> From: Julia Lawall <julia.lawall@lip6.fr>
> Date: Tue, 19 Jan 2016 19:54:20 +0100 (CET)
[...]
> > I just wondered. I was looking at dependencies between networking files.
> > This one stands out because nothing is dependenton it, even the files it
> > is compiled with, and it doesn't contain the usual functions,
> > register_netdev, etc.
>
> Even with that explanation, this is a bogus situation.
>
> There are no in-tree callers of this code. It should be removed until there
> are in-tree users.
>
> Nobody can figure out if the interface for this is done properly without seeing
> the call sites and how they work. It is therefore impossible to review this
> code and judge it's design.
>
> If someone doesn't send me a removal patch, I will remove this code myself.
I have the patch ready.
Do you want me to submit it now during the merge window or wait till
net-next opens up again?
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: question about samsung/sxgbe/sxgbe_xpcs.c
2016-01-21 5:10 ` Jεan Sacren
@ 2016-01-21 14:04 ` Shuah Khan
2016-01-21 19:09 ` David Miller
2016-01-21 18:45 ` David Miller
1 sibling, 1 reply; 9+ messages in thread
From: Shuah Khan @ 2016-01-21 14:04 UTC (permalink / raw)
To: Jεan Sacren, David Miller, siva.kallam
Cc: julia.lawall, shuahkhan, bh74.an, ks.giri, vipul.pandya, netdev,
linux-kernel
On 01/20/2016 10:10 PM, Jεan Sacren wrote:
> From: David Miller <davem@davemloft.net>
> Date: Tue, 19 Jan 2016 14:36:28 -0500
>>
>> From: Julia Lawall <julia.lawall@lip6.fr>
>> Date: Tue, 19 Jan 2016 19:54:20 +0100 (CET)
>
> [...]
>
>>> I just wondered. I was looking at dependencies between networking files.
>>> This one stands out because nothing is dependenton it, even the files it
>>> is compiled with, and it doesn't contain the usual functions,
>>> register_netdev, etc.
>>
>> Even with that explanation, this is a bogus situation.
>>
>> There are no in-tree callers of this code. It should be removed until there
>> are in-tree users.
>>
>> Nobody can figure out if the interface for this is done properly without seeing
>> the call sites and how they work. It is therefore impossible to review this
>> code and judge it's design.
>>
>> If someone doesn't send me a removal patch, I will remove this code myself.
>
> I have the patch ready.
>
> Do you want me to submit it now during the merge window or wait till
> net-next opens up again?
>
My second attempt to locate the author for a comment
on this before it gets removed. Maybe this code could
be fixed just in case it is important for some product
out there.
I am cc'ing the original author in case he has any
comments.
thanks,
-- Shuah
--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: question about samsung/sxgbe/sxgbe_xpcs.c
2016-01-21 14:04 ` Shuah Khan
@ 2016-01-21 19:09 ` David Miller
0 siblings, 0 replies; 9+ messages in thread
From: David Miller @ 2016-01-21 19:09 UTC (permalink / raw)
To: shuahkh
Cc: sakiwit, siva.kallam, julia.lawall, shuahkhan, bh74.an, ks.giri,
vipul.pandya, netdev, linux-kernel
From: Shuah Khan <shuahkh@osg.samsung.com>
Date: Thu, 21 Jan 2016 07:04:17 -0700
> On 01/20/2016 10:10 PM, Jεan Sacren wrote:
>> From: David Miller <davem@davemloft.net>
>> Date: Tue, 19 Jan 2016 14:36:28 -0500
>>>
>>> From: Julia Lawall <julia.lawall@lip6.fr>
>>> Date: Tue, 19 Jan 2016 19:54:20 +0100 (CET)
>>
>> [...]
>>
>>>> I just wondered. I was looking at dependencies between networking files.
>>>> This one stands out because nothing is dependenton it, even the files it
>>>> is compiled with, and it doesn't contain the usual functions,
>>>> register_netdev, etc.
>>>
>>> Even with that explanation, this is a bogus situation.
>>>
>>> There are no in-tree callers of this code. It should be removed until there
>>> are in-tree users.
>>>
>>> Nobody can figure out if the interface for this is done properly without seeing
>>> the call sites and how they work. It is therefore impossible to review this
>>> code and judge it's design.
>>>
>>> If someone doesn't send me a removal patch, I will remove this code myself.
>>
>> I have the patch ready.
>>
>> Do you want me to submit it now during the merge window or wait till
>> net-next opens up again?
>>
>
> My second attempt to locate the author for a comment
> on this before it gets removed. Maybe this code could
> be fixed just in case it is important for some product
> out there.
>
> I am cc'ing the original author in case he has any
> comments.
It never should have been added in the first place, I really don't
care at all right now what it's used for.
The simple fact is that it isn't used, and therefore must be removed
now.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: question about samsung/sxgbe/sxgbe_xpcs.c
2016-01-21 5:10 ` Jεan Sacren
2016-01-21 14:04 ` Shuah Khan
@ 2016-01-21 18:45 ` David Miller
2016-01-21 19:32 ` Jεan Sacren
1 sibling, 1 reply; 9+ messages in thread
From: David Miller @ 2016-01-21 18:45 UTC (permalink / raw)
To: sakiwit
Cc: julia.lawall, shuahkhan, bh74.an, ks.giri, vipul.pandya, netdev,
linux-kernel, shuahkh
From: Jεan Sacren <sakiwit@gmail.com>
Date: Wed, 20 Jan 2016 22:10:56 -0700
> From: David Miller <davem@davemloft.net>
> Date: Tue, 19 Jan 2016 14:36:28 -0500
>>
>> From: Julia Lawall <julia.lawall@lip6.fr>
>> Date: Tue, 19 Jan 2016 19:54:20 +0100 (CET)
>
> [...]
>
>> > I just wondered. I was looking at dependencies between networking files.
>> > This one stands out because nothing is dependenton it, even the files it
>> > is compiled with, and it doesn't contain the usual functions,
>> > register_netdev, etc.
>>
>> Even with that explanation, this is a bogus situation.
>>
>> There are no in-tree callers of this code. It should be removed until there
>> are in-tree users.
>>
>> Nobody can figure out if the interface for this is done properly without seeing
>> the call sites and how they work. It is therefore impossible to review this
>> code and judge it's design.
>>
>> If someone doesn't send me a removal patch, I will remove this code myself.
>
> I have the patch ready.
>
> Do you want me to submit it now during the merge window or wait till
> net-next opens up again?
This is rediculous.
No, you cannot submit patches for new features now.
Yes, you will submit to me a patch to remove the unused code.
Am I being clear enough now?
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: question about samsung/sxgbe/sxgbe_xpcs.c
2016-01-21 18:45 ` David Miller
@ 2016-01-21 19:32 ` Jεan Sacren
0 siblings, 0 replies; 9+ messages in thread
From: Jεan Sacren @ 2016-01-21 19:32 UTC (permalink / raw)
To: David Miller
Cc: julia.lawall, shuahkhan, bh74.an, ks.giri, vipul.pandya, netdev,
linux-kernel, shuahkh
From: David Miller <davem@davemloft.net>
Date: Thu, 21 Jan 2016 10:45:20 -0800
>
> Yes, you will submit to me a patch to remove the unused code.
I should have paraphrased it better:
"I have the patch ready and will submit it when net-next opens again."
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2016-01-21 19:32 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-19 16:26 question about samsung/sxgbe/sxgbe_xpcs.c Julia Lawall
2016-01-19 18:18 ` Shuah Khan
2016-01-19 18:54 ` Julia Lawall
2016-01-19 19:36 ` David Miller
2016-01-21 5:10 ` Jεan Sacren
2016-01-21 14:04 ` Shuah Khan
2016-01-21 19:09 ` David Miller
2016-01-21 18:45 ` David Miller
2016-01-21 19:32 ` Jεan Sacren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).