From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net v2] gro: Make GRO aware of lightweight tunnels. Date: Wed, 20 Jan 2016 18:50:09 -0800 (PST) Message-ID: <20160120.185009.540864680237250881.davem@davemloft.net> References: <1453341589-53612-1-git-send-email-jesse@kernel.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com, tgraf@suug.ch, john.phillips5@hpe.com To: jesse@kernel.org Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:40461 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757843AbcAUCuN (ORCPT ); Wed, 20 Jan 2016 21:50:13 -0500 In-Reply-To: <1453341589-53612-1-git-send-email-jesse@kernel.org> Sender: netdev-owner@vger.kernel.org List-ID: From: Jesse Gross Date: Wed, 20 Jan 2016 17:59:49 -0800 > GRO is currently not aware of tunnel metadata generated by lightweight > tunnels and stored in the dst. This leads to two possible problems: > * Incorrectly merging two frames that have different metadata. > * Leaking of allocated metadata from merged frames. > > This avoids those problems by comparing the tunnel information before > merging, similar to how we handle other metadata (such as vlan tags), > and releasing any state when we are done. > > Reported-by: John > Fixes: 2e15ea39 ("ip_gre: Add support to collect tunnel metadata.") > Signed-off-by: Jesse Gross > --- > v2: Remove branches to optimize for common case where there is no dst. Applied and queued up for -stable, thanks.