netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Richard Cochran <richardcochran@gmail.com>
To: Manfred Rudigier <manfred.rudigier@omicron.at>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH] net: dp83640: Fix tx timestamp overflow handling.
Date: Wed, 20 Jan 2016 14:25:45 +0100	[thread overview]
Message-ID: <20160120132545.GB2032@netboy> (raw)
In-Reply-To: <1453285348-16022-1-git-send-email-manfred.rudigier@omicron.at>

On Wed, Jan 20, 2016 at 11:22:28AM +0100, Manfred Rudigier wrote:
> PHY status frames are not reliable, the PHY may not be able to send them
> during heavy receive traffic. This overflow condition is signaled by the
> PHY in the next status frame, but the driver did not make use of it.
> Instead it always reported wrong tx timestamps to user space after an
> overflow happened because it assigned newly received tx timestamps to old
> packets in the queue.
> 
> This commit fixes this issue by clearing the tx timestamp queue every time
> an overflow happens, so that no timestamps are delivered for overflow
> packets. This way time stamping will continue correctly after an overflow.

Hi Manfred,

Thanks for finding and fixing this bug.

Dave, this patch should also go into stable.

Acked-by: Richard Cochran <richardcochran@gmail.com>

  reply	other threads:[~2016-01-20 13:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-20 10:22 [PATCH] net: dp83640: Fix tx timestamp overflow handling Manfred Rudigier
2016-01-20 13:25 ` Richard Cochran [this message]
2016-01-21  2:54   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160120132545.GB2032@netboy \
    --to=richardcochran@gmail.com \
    --cc=davem@davemloft.net \
    --cc=manfred.rudigier@omicron.at \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).