From: Thomas Graf <tgraf@suug.ch>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Jesse Gross <jesse@kernel.org>, John <john.phillips5@hpe.com>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
Tom Herbert <tom@herbertland.com>,
david.roth@hpe.com, Pravin B Shelar <pshelar@nicira.com>
Subject: Re: Kernel memory leak in bnx2x driver with vxlan tunnel
Date: Thu, 21 Jan 2016 03:27:34 +0100 [thread overview]
Message-ID: <20160121022734.GC29853@pox.localdomain> (raw)
In-Reply-To: <1453336495.1223.341.camel@edumazet-glaptop2.roam.corp.google.com>
On 01/20/16 at 04:34pm, Eric Dumazet wrote:
> On Wed, 2016-01-20 at 16:19 -0800, Jesse Gross wrote:
>
> > I have a patch that implements the comparison between dsts. For
> > packets without a dst, there isn't really a cost and if we do have a
> > dst then GRO is still a benefit. So it seems like it is worth doing,
> > even if it is more expensive than is ideal.
>
> You guys really want to kill GRO performance.
>
> Really the aggregation should happen at the first layer (ethernet
> device), instead of doing it after tunnel decap.
>
> This is already done for GRE, IPIP, SIT, ...
>
> GRO having to access metadata looks wrong, if you think about trying to
> do the same function in hardware (offload)
If I understand Jesse correctly then the added cost is only for
metadata enabled packets. Though I agree, what's the benefit of
doing GRO after decap?
It seems like it's way too late and we've already paid the cost
by going through the stack for each outer header packet.
prev parent reply other threads:[~2016-01-21 2:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-14 17:17 Kernel memory leak in bnx2x driver with vxlan tunnel John
2016-01-19 21:07 ` Jesse Gross
2016-01-19 22:47 ` Eric Dumazet
2016-01-19 23:34 ` Jesse Gross
2016-01-19 23:51 ` Eric Dumazet
2016-01-20 0:00 ` Jesse Gross
2016-01-20 0:17 ` Eric Dumazet
2016-01-20 0:51 ` Jesse Gross
2016-01-20 1:31 ` Thomas Graf
2016-01-20 1:40 ` Jesse Gross
2016-01-20 23:43 ` John
2016-01-21 0:07 ` Eric Dumazet
2016-01-21 0:19 ` Jesse Gross
2016-01-21 0:34 ` Eric Dumazet
2016-01-21 2:27 ` Thomas Graf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160121022734.GC29853@pox.localdomain \
--to=tgraf@suug.ch \
--cc=david.roth@hpe.com \
--cc=eric.dumazet@gmail.com \
--cc=jesse@kernel.org \
--cc=john.phillips5@hpe.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).