From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Graf Subject: Re: [PATCH net v2] gro: Make GRO aware of lightweight tunnels. Date: Thu, 21 Jan 2016 03:34:15 +0100 Message-ID: <20160121023415.GE29853@pox.localdomain> References: <1453341589-53612-1-git-send-email-jesse@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: David Miller , netdev@vger.kernel.org, Eric Dumazet , John To: Jesse Gross Return-path: Received: from mail-wm0-f46.google.com ([74.125.82.46]:35053 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751018AbcAUCeR (ORCPT ); Wed, 20 Jan 2016 21:34:17 -0500 Received: by mail-wm0-f46.google.com with SMTP id r129so154444162wmr.0 for ; Wed, 20 Jan 2016 18:34:17 -0800 (PST) Content-Disposition: inline In-Reply-To: <1453341589-53612-1-git-send-email-jesse@kernel.org> Sender: netdev-owner@vger.kernel.org List-ID: On 01/20/16 at 05:59pm, Jesse Gross wrote: > GRO is currently not aware of tunnel metadata generated by lightweight > tunnels and stored in the dst. This leads to two possible problems: > * Incorrectly merging two frames that have different metadata. > * Leaking of allocated metadata from merged frames. > > This avoids those problems by comparing the tunnel information before > merging, similar to how we handle other metadata (such as vlan tags), > and releasing any state when we are done. > > Reported-by: John > Fixes: 2e15ea39 ("ip_gre: Add support to collect tunnel metadata.") > Signed-off-by: Jesse Gross Acked-by: Thomas Graf Thanks Jesse