From: "Jεan Sacren" <sakiwit@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: julia.lawall@lip6.fr, shuahkhan@gmail.com, bh74.an@samsung.com,
ks.giri@samsung.com, vipul.pandya@samsung.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
shuahkh@osg.samsung.com
Subject: Re: question about samsung/sxgbe/sxgbe_xpcs.c
Date: Wed, 20 Jan 2016 22:10:56 -0700 [thread overview]
Message-ID: <20160121051056.GA4373@mail.gmail.com> (raw)
In-Reply-To: <20160119.143628.432983847877790677.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Tue, 19 Jan 2016 14:36:28 -0500
>
> From: Julia Lawall <julia.lawall@lip6.fr>
> Date: Tue, 19 Jan 2016 19:54:20 +0100 (CET)
[...]
> > I just wondered. I was looking at dependencies between networking files.
> > This one stands out because nothing is dependenton it, even the files it
> > is compiled with, and it doesn't contain the usual functions,
> > register_netdev, etc.
>
> Even with that explanation, this is a bogus situation.
>
> There are no in-tree callers of this code. It should be removed until there
> are in-tree users.
>
> Nobody can figure out if the interface for this is done properly without seeing
> the call sites and how they work. It is therefore impossible to review this
> code and judge it's design.
>
> If someone doesn't send me a removal patch, I will remove this code myself.
I have the patch ready.
Do you want me to submit it now during the merge window or wait till
net-next opens up again?
next prev parent reply other threads:[~2016-01-21 5:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 16:26 question about samsung/sxgbe/sxgbe_xpcs.c Julia Lawall
2016-01-19 18:18 ` Shuah Khan
2016-01-19 18:54 ` Julia Lawall
2016-01-19 19:36 ` David Miller
2016-01-21 5:10 ` Jεan Sacren [this message]
2016-01-21 14:04 ` Shuah Khan
2016-01-21 19:09 ` David Miller
2016-01-21 18:45 ` David Miller
2016-01-21 19:32 ` Jεan Sacren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160121051056.GA4373@mail.gmail.com \
--to=sakiwit@gmail.com \
--cc=bh74.an@samsung.com \
--cc=davem@davemloft.net \
--cc=julia.lawall@lip6.fr \
--cc=ks.giri@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shuahkh@osg.samsung.com \
--cc=shuahkhan@gmail.com \
--cc=vipul.pandya@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).