From: Andrew Lunn <andrew@lunn.ch>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH] net: dsa: fix mv88e6xxx switches
Date: Sat, 23 Jan 2016 23:23:26 +0100 [thread overview]
Message-ID: <20160123222326.GK3880@lunn.ch> (raw)
In-Reply-To: <20160123221232.GJ3880@lunn.ch>
On Sat, Jan 23, 2016 at 11:12:32PM +0100, Andrew Lunn wrote:
> > This shows port 0 is on vlan 0, but it should default to vlan 1 when
> > no vlans are configured. The patch below should at least allow some
> > diagnosis of what's being requested, and when.
> >
> > diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c
> > index a43354ed0607..8a9cf67eb16d 100644
> > --- a/drivers/net/dsa/mv88e6xxx.c
> > +++ b/drivers/net/dsa/mv88e6xxx.c
> > @@ -1511,6 +1511,9 @@ int mv88e6xxx_port_vlan_add(struct dsa_switch *ds, int port,
> > u16 vid;
> > int err = 0;
> >
> > + printk("%s: port %d vid %u-%u flags %x\n",
> > + __func__, port, vlan->vid_begin, vlan->vid_end, vlan->flags);
> > +
>
> Hi Russell
>
> Never called.
>
> So i guess we have a kernel configuration difference.
>
> I don't have CONFIG_BRIDGE_VLAN_FILTERING.
Yep, confirmed. When i enable this option, and VLAN_8021Q which it
depends on, i then have a working bridge.
Andrew
next prev parent reply other threads:[~2016-01-23 22:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-23 10:51 [PATCH] net: dsa: fix mv88e6xxx switches Russell King
2016-01-23 18:15 ` Andrew Lunn
2016-01-23 19:06 ` Russell King - ARM Linux
2016-01-23 19:37 ` Andrew Lunn
2016-01-23 19:48 ` Russell King - ARM Linux
2016-01-23 20:16 ` Andrew Lunn
2016-01-23 20:44 ` Russell King - ARM Linux
2016-01-23 22:12 ` Andrew Lunn
2016-01-23 22:23 ` Andrew Lunn [this message]
2016-01-23 23:31 ` Russell King - ARM Linux
2016-01-24 6:01 ` Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160123222326.GK3880@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux@arm.linux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).