From: David Miller <davem@davemloft.net>
To: martin.roth@motorolasolutions.com
Cc: pantelis.antoniou@gmail.com, vbordug@ru.mvista.com,
linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] 82xx: FCC: Fixing a bug causing to FCC port lock-up (second try)
Date: Mon, 25 Jan 2016 10:47:28 -0800 (PST) [thread overview]
Message-ID: <20160125.104728.1314622892837934779.davem@davemloft.net> (raw)
In-Reply-To: <1453589779-13187-1-git-send-email-martin.roth@motorolasolutions.com>
From: Martin Roth <martin.roth@motorolasolutions.com>
Date: Sun, 24 Jan 2016 00:56:19 +0200
> This is an additional patch to the one already submitted recently.
> The previous patch was not complete, and the FCC port lock-up scenario
> has been reproduced in lab.
> I had an opportunity to check the current patch in lab and the FCC
> port lock no longer freezes, while the previous patch still locks-up the
> FCC port.
> The current patch fixes a pointer arithmetic bug (second bug in the same
> line), which leads FCC port lock-up during underrun/collision handling.
> Within the tx_startup() function in mac-fcc.c, the address of last BD is
> not calculated correctly. As a result of wrong calculation of the last BD
> address, the next transmitted BD may be set to an area out of the transmit
> BD ring. This actually causes to port lock-up and it is not recoverable.
>
> Signed-off-by: Martin Roth <martin.roth@motorolasolutions.com>
Applied, thank you.
prev parent reply other threads:[~2016-01-25 18:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-23 22:56 [PATCH] 82xx: FCC: Fixing a bug causing to FCC port lock-up (second try) Martin Roth
2016-01-25 18:47 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160125.104728.1314622892837934779.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=martin.roth@motorolasolutions.com \
--cc=netdev@vger.kernel.org \
--cc=pantelis.antoniou@gmail.com \
--cc=stable@vger.kernel.org \
--cc=vbordug@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).