public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Flavio Leitner <fbl@sysclose.org>
To: netdev <netdev@vger.kernel.org>, Scott Feldman <sfeldma@gmail.com>
Cc: Jiri Pirko <jiri@resnulli.us>
Subject: Cannot set ageing to zero
Date: Tue, 26 Jan 2016 15:26:30 -0200	[thread overview]
Message-ID: <20160126152630.422f5ac4@x240.home> (raw)


Hi,

After the commit[1] below, we can't set ageing on a Linux bridge device
to zero.  It seems rocker needs the minimum value, but we can't break
an old and valid Linux bridge behavior. 

[1] commit c62987bbd8a1a1664f99e89e3959339350a6131e
Author: Scott Feldman <sfeldma@gmail.com>
Date:   Thu Oct 8 19:23:19 2015 -0700

    bridge: push bridge setting ageing_time down to switchdev
    
    Use SWITCHDEV_F_SKIP_EOPNOTSUPP to skip over ports in bridge that
    don't support setting ageing_time (or setting bridge attrs in
    general). 
    If push fails, don't update ageing_time in bridge and return err to
    user. 
    If push succeeds, update ageing_time in bridge and run gc_timer now
    to recalabrate when to run gc_timer next, based on new ageing_time.
    
    Signed-off-by: Scott Feldman <sfeldma@gmail.com>
    Signed-off-by: Jiri Pirko <jiri@resnulli.us>
    Acked-by: Jiri Pirko <jiri@mellanox.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>


-- 
fbl

             reply	other threads:[~2016-01-26 17:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-26 17:26 Flavio Leitner [this message]
2016-01-26 17:30 ` Cannot set ageing to zero Jiri Pirko
2016-01-26 17:44   ` Flavio Leitner
2016-01-26 17:48     ` Jiri Pirko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160126152630.422f5ac4@x240.home \
    --to=fbl@sysclose.org \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=sfeldma@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox