From mboxrd@z Thu Jan 1 00:00:00 1970 From: Flavio Leitner Subject: Re: Cannot set ageing to zero Date: Tue, 26 Jan 2016 15:44:24 -0200 Message-ID: <20160126154424.68185099@x240.home> References: <20160126152630.422f5ac4@x240.home> <20160126173041.GD2195@nanopsycho.orion> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev , Scott Feldman To: Jiri Pirko Return-path: Received: from sender163-mail.zoho.com ([74.201.84.163]:25067 "EHLO sender163-mail.zoho.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756028AbcAZRoC (ORCPT ); Tue, 26 Jan 2016 12:44:02 -0500 In-Reply-To: <20160126173041.GD2195@nanopsycho.orion> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 26 Jan 2016 18:30:41 +0100 Jiri Pirko wrote: > Tue, Jan 26, 2016 at 06:26:30PM CET, fbl@sysclose.org wrote: > > > >Hi, > > > >After the commit[1] below, we can't set ageing on a Linux bridge > >device to zero. It seems rocker needs the minimum value, but we > >can't break an old and valid Linux bridge behavior. > > The commit below adds check if the value being set is within > BR_MIN_AGEING_TIME and BR_MAX_AGEING_TIME. I believe that the check is > correct as it implements the standard. > > Why do you set ageing_time to 0? Why don't just just disable learning? It's a documented behavior: http://www.linuxcertif.com/man/5/ifcfg-bridge/ http://www.linuxfoundation.org/collaborate/workgroups/networking/bridge http://comments.gmane.org/gmane.linux.network.bridge/2060 fbl > > > > > >[1] commit c62987bbd8a1a1664f99e89e3959339350a6131e > >Author: Scott Feldman > >Date: Thu Oct 8 19:23:19 2015 -0700 > > > > bridge: push bridge setting ageing_time down to switchdev > > > > Use SWITCHDEV_F_SKIP_EOPNOTSUPP to skip over ports in bridge that > > don't support setting ageing_time (or setting bridge attrs in > > general). > > If push fails, don't update ageing_time in bridge and return err > > to user. > > If push succeeds, update ageing_time in bridge and run gc_timer > > now to recalabrate when to run gc_timer next, based on new > > ageing_time. > > Signed-off-by: Scott Feldman > > Signed-off-by: Jiri Pirko > > Acked-by: Jiri Pirko > > Signed-off-by: David S. Miller > > > > > >-- > >fbl > > -- fbl