From: David Miller <davem@davemloft.net>
To: joe@ovn.org
Cc: netdev@vger.kernel.org, fw@strlen.de, hannes@stressinduktion.org,
pshelar@ovn.org
Subject: Re: [PATCH net] inet: frag: Always orphan skbs inside ip_defrag()
Date: Thu, 28 Jan 2016 16:02:06 -0800 (PST) [thread overview]
Message-ID: <20160128.160206.1148428775767129968.davem@davemloft.net> (raw)
In-Reply-To: <1453506552-10373-1-git-send-email-joe@ovn.org>
From: Joe Stringer <joe@ovn.org>
Date: Fri, 22 Jan 2016 15:49:12 -0800
> Later parts of the stack (including fragmentation) expect that there is
> never a socket attached to frag in a frag_list, however this invariant
> was not enforced on all defrag paths. This could lead to the
> BUG_ON(skb->sk) during ip_do_fragment(), as per the call stack at the
> end of this commit message.
>
> While the call could be added to openvswitch to fix this particular
> error, the head and tail of the frags list are already orphaned
> indirectly inside ip_defrag(), so it seems like the remaining fragments
> should all be orphaned in all circumstances.
...
> Fixes: 7f8a436eaa2c ("openvswitch: Add conntrack action")
> Signed-off-by: Joe Stringer <joe@ovn.org>
Applied and queued up for -stable, thanks Joe.
prev parent reply other threads:[~2016-01-29 0:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-22 23:49 [PATCH net] inet: frag: Always orphan skbs inside ip_defrag() Joe Stringer
2016-01-23 1:22 ` Eric Dumazet
2016-01-26 1:11 ` Joe Stringer
2016-01-26 5:58 ` Eric Dumazet
2016-01-27 0:59 ` [PATCH net] ipv4: early demux should be aware of fragments Eric Dumazet
2016-01-27 22:02 ` David Miller
2016-01-29 15:22 ` Eric Dumazet
2016-01-29 20:24 ` David Miller
2016-01-29 20:57 ` Eric Dumazet
2016-01-27 2:16 ` [PATCH net] inet: frag: Always orphan skbs inside ip_defrag() Joe Stringer
2016-01-29 0:02 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160128.160206.1148428775767129968.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=hannes@stressinduktion.org \
--cc=joe@ovn.org \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).