From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] tcp: beware of alignments in tcp_get_info()
Date: Thu, 28 Jan 2016 22:50:26 -0800 (PST) [thread overview]
Message-ID: <20160128.225026.2097479414986216382.davem@davemloft.net> (raw)
In-Reply-To: <1453920763.20722.23.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 27 Jan 2016 10:52:43 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> With some combinations of user provided flags in netlink command,
> it is possible to call tcp_get_info() with a buffer that is not 8-bytes
> aligned.
>
> It does matter on some arches, so we need to use put_unaligned() to
> store the u64 fields.
>
> Current iproute2 package does not trigger this particular issue.
>
> Fixes: 0df48c26d841 ("tcp: add tcpi_bytes_acked to tcp_info")
> Fixes: 977cb0ecf82e ("tcp: add pacing_rate information into tcp_info")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied and queued up for -stable, thanks Eric.
prev parent reply other threads:[~2016-01-29 6:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 18:52 [PATCH net] tcp: beware of alignments in tcp_get_info() Eric Dumazet
2016-01-29 6:50 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160128.225026.2097479414986216382.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).