From: David Miller <davem@davemloft.net>
To: jay.vosburgh@canonical.com
Cc: netdev@vger.kernel.org, vfalico@gmail.com, gospo@cumulusnetworks.com
Subject: Re: [PATCH net] bonding: Fix ARP monitor validation
Date: Fri, 29 Jan 2016 20:07:53 -0800 (PST) [thread overview]
Message-ID: <20160129.200753.416219877672699488.davem@davemloft.net> (raw)
In-Reply-To: <16766.1454031188@famine>
From: Jay Vosburgh <jay.vosburgh@canonical.com>
Date: Thu, 28 Jan 2016 17:33:08 -0800
> + else if (curr_arp_slave && (arp->ar_op == htons(ARPOP_REPLY)) &&
> + bond_time_in_interval(bond,
> + dev_trans_start(curr_arp_slave->dev), 1))
> + bond_validate_arp(bond, slave, sip, tip);
Please document this timeout condition, both in your commit message and in
the "We 'trust' the arp requests..." comment.
Thanks.
prev parent reply other threads:[~2016-01-30 4:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 1:33 [PATCH net] bonding: Fix ARP monitor validation Jay Vosburgh
2016-01-30 4:07 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160129.200753.416219877672699488.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gospo@cumulusnetworks.com \
--cc=jay.vosburgh@canonical.com \
--cc=netdev@vger.kernel.org \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).