From: David Miller <davem@davemloft.net>
To: chamaken@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] netlink: not trim skb for mmaped socket when dump
Date: Fri, 29 Jan 2016 20:25:42 -0800 (PST) [thread overview]
Message-ID: <20160129.202542.2079689880141524449.davem@davemloft.net> (raw)
In-Reply-To: <20160129014549.GA28672@gmail.com>
From: Ken-ichirou MATSUZAWA <chamaken@gmail.com>
Date: Fri, 29 Jan 2016 10:45:50 +0900
> We should not trim skb for mmaped socket since its buf size is fixed
> and userspace will read as frame which data equals head. mmaped
> socket will not call recvmsg, means max_recvmsg_len is 0,
> skb_reserve was not called before commit: db65a3aaf29e.
>
> Fixes: db65a3aaf29e (netlink: Trim skb to alloc size to avoid MSG_TRUNC)
> Signed-off-by: Ken-ichirou MATSUZAWA <chamas@h4.dion.ne.jp>
Applied, thank you.
prev parent reply other threads:[~2016-01-30 4:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 1:45 [PATCH net] netlink: not trim skb for mmaped socket when dump Ken-ichirou MATSUZAWA
2016-01-30 4:25 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160129.202542.2079689880141524449.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chamaken@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).