From: David Miller <davem@davemloft.net>
To: pabeni@redhat.com
Cc: netdev@vger.kernel.org, dsa@cumulusnetworks.com,
thehajime@gmail.com, lucien.xin@gmail.com,
marcelo.leitner@gmail.com, hannes@stressinduktion.org,
yoshfuji@linux-ipv6.org
Subject: Re: [PATCH net v2 0/2] pv6: fix sticky pktinfo behaviour
Date: Fri, 29 Jan 2016 20:31:47 -0800 (PST) [thread overview]
Message-ID: <20160129.203147.89087242679903549.davem@davemloft.net> (raw)
In-Reply-To: <cover.1454066754.git.pabeni@redhat.com>
From: Paolo Abeni <pabeni@redhat.com>
Date: Fri, 29 Jan 2016 12:30:18 +0100
> Currently:
>
> ip addr add dev eth0 2001:0010::1/64
> ip addr add dev eth1 2001:0020::1/64
> ping6 -I eth0 2001:0020::2
>
> do not lead to the expected results, i.e. eth1 is used as the
> egress interface.
>
> This is due to two related issues in handling sticky pktinfo,
> used by ping6 to enforce the device binding:
>
> - ip6_dst_lookup_flow()/ip6_dst_lookup_tail() do not really enforce
> flowi6_oif match
> - ipv6 udp connect() just ignore flowi6_oif
>
> These patches address each issue individually.
>
> The kernel has never enforced the egress interface specified
> via the sticky pktinfo, except briefly between the commits
> 741a11d9e410 ("net: ipv6: Add RT6_LOOKUP_F_IFACE flag if oif is set")
> and
> d46a9d678e4c ("net: ipv6: Dont add RT6_LOOKUP_F_IFACE flag if saddr set"),
> but the ping6 tools was unaffected up to iputils-20100214,
> since before it used SO_BINDTODEVICE to enforce the egress
> interface.
Series applied, thanks.
prev parent reply other threads:[~2016-01-30 4:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 11:30 [PATCH net v2 0/2] pv6: fix sticky pktinfo behaviour Paolo Abeni
2016-01-29 11:30 ` [PATCH net v2 1/2] ipv6: enforce flowi6_oif usage in ip6_dst_lookup_tail() Paolo Abeni
2016-01-29 12:33 ` Hannes Frederic Sowa
2016-02-01 2:24 ` YOSHIFUJI Hideaki
2016-01-29 16:00 ` David Ahern
2016-01-29 11:30 ` [PATCH net v2 2/2] ipv6/udp: use sticky pktinfo egress ifindex on connect() Paolo Abeni
2016-01-29 12:33 ` Hannes Frederic Sowa
2016-02-01 2:23 ` YOSHIFUJI Hideaki
2016-02-02 2:06 ` David Ahern
2016-02-02 2:18 ` David Miller
2016-01-29 12:36 ` [PATCH net v2 0/2] pv6: fix sticky pktinfo behaviour Hannes Frederic Sowa
2016-01-30 4:31 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160129.203147.89087242679903549.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=hannes@stressinduktion.org \
--cc=lucien.xin@gmail.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thehajime@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).