netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net v4] r8169:   Disable force bus mastering
@ 2016-02-01 13:38 Corcodel Marian
  2016-02-01 19:36 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Corcodel Marian @ 2016-02-01 13:38 UTC (permalink / raw)
  To: netdev; +Cc: Corcodel Marian

Do not need to force on bus mastering , if alls is ok this is
enabled on BIOS.

Signed-off-by: Corcodel Marian <asd@marian1000.go.ro>
---
 drivers/net/ethernet/realtek/r8169.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
index a8fb86d..8476659 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c
@@ -7915,7 +7915,6 @@ static void rtl_wol_shutdown_quirk(struct rtl8169_private *tp)
 	case RTL_GIGA_MAC_VER_11:
 	case RTL_GIGA_MAC_VER_12:
 	case RTL_GIGA_MAC_VER_17:
-		pci_clear_master(tp->pci_dev);
 
 		RTL_W8(ChipCmd, CmdRxEnb);
 		/* PCI commit */
@@ -8256,7 +8255,6 @@ static int rtl_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 
 	rtl_ack_events(tp, 0xffff);
 
-	pci_set_master(pdev);
 
 	rtl_init_mdio_ops(tp);
 	rtl_init_pll_power_ops(tp);
-- 
2.5.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net v4] r8169: Disable force bus mastering
  2016-02-01 13:38 [PATCH net v4] r8169: Disable force bus mastering Corcodel Marian
@ 2016-02-01 19:36 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-02-01 19:36 UTC (permalink / raw)
  To: asd; +Cc: netdev

From: Corcodel Marian <asd@marian1000.go.ro>
Date: Mon,  1 Feb 2016 15:38:16 +0200

> Do not need to force on bus mastering , if alls is ok this is
> enabled on BIOS.
> 
> Signed-off-by: Corcodel Marian <asd@marian1000.go.ro>

The chip can be used on systems without a BIOS and that should still
work.

The driver must fully program the card.

I'm not applying this.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-02-01 19:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-01 13:38 [PATCH net v4] r8169: Disable force bus mastering Corcodel Marian
2016-02-01 19:36 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).