From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
Tom Herbert <tom@herbertland.com>,
davem@davemloft.net, netdev@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH net] net: Allow flow dissector to handle non 4-byte aligned headers
Date: Mon, 1 Feb 2016 11:01:30 -0500 [thread overview]
Message-ID: <20160201160130.GA22816@oracle.com> (raw)
In-Reply-To: <56AF77C3.2010406@6wind.com>
On (02/01/16 16:20), Nicolas Dichtel wrote:
> There is also the tile architecture, up to 76 cores on the board I've seen. It
> requires an alignment on 8!
> I wonder how this case may be properly handled. A simple ipip scenario fails.
Yes, I'm also observing the same thing. Simply setting up gretap like this
results in
# ip link add gretap2 type gretap local myaddr remote hisaddr
# ifconfig gretap2 up
Kernel unaligned access at TPC[969d88] iptunnel_xmit+0xa4/0x1c0
Kernel unaligned access at TPC[969db0] iptunnel_xmit+0xcc/0x1c0
Kernel unaligned access at TPC[969dc4] iptunnel_xmit+0xe0/0x1c0
Kernel unaligned access at TPC[969dc8] iptunnel_xmit+0xe4/0x1c0
Kernel unaligned access at TPC[9191fc] __ip_select_ident+0x80/0x13c
and afacit, the unaligned ip header is triggered by an inner ipv6 packet
that is usually coming from mld or dad.
(and fwiw, the basic iperf/ipv6 test is fine with Tom's patch, need
to try out some of the other permutations without rps etc)
next prev parent reply other threads:[~2016-02-01 16:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-31 21:37 [PATCH net] net: Allow flow dissector to handle non 4-byte aligned headers Tom Herbert
2016-01-31 21:47 ` kbuild test robot
2016-01-31 22:06 ` Florian Westphal
2016-02-01 0:24 ` Eric Dumazet
2016-02-01 0:39 ` Florian Fainelli
2016-02-01 15:20 ` Nicolas Dichtel
2016-02-01 16:01 ` Sowmini Varadhan [this message]
2016-02-01 0:43 ` Sowmini Varadhan
2016-02-01 12:32 ` Sergei Shtylyov
2016-02-02 0:31 ` Sowmini Varadhan
2016-02-02 0:46 ` Tom Herbert
2016-02-02 3:56 ` Alexander Duyck
2016-02-02 13:41 ` Hannes Frederic Sowa
2016-02-02 18:35 ` Sowmini Varadhan
2016-02-03 17:07 ` Tom Herbert
2016-02-03 17:31 ` Sowmini Varadhan
2016-02-03 17:51 ` Tom Herbert
2016-02-03 17:59 ` Sowmini Varadhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160201160130.GA22816@oracle.com \
--to=sowmini.varadhan@oracle.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).