From: Jiri Benc <jbenc@redhat.com>
To: Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 5/5] vxlan: consolidate vxlan_xmit_skb and vxlan6_xmit_skb
Date: Tue, 2 Feb 2016 16:06:21 +0100 [thread overview]
Message-ID: <20160202160621.086e710c@griffin> (raw)
In-Reply-To: <1454425043.5523.21.camel@redhat.com>
On Tue, 02 Feb 2016 15:57:23 +0100, Paolo Abeni wrote:
> I think there is an issue here: in vxlan_build_skb(), 'flags' will be
> always tested against VXLAN_F_UDP_CSUM, but when tunneling over ipv6 we
> should check VXLAN_F_UDP_ZERO_CSUM6_TX instead.
You're correct. This IPv4/v6 flags schism is a source of constant pain.
Thanks for noticing it.
> Probably an explicit 'udp_sum' argument should be added to
> vxlan_build_skb().
Yes, I'm already working on a patch and will resubmit the set.
Thanks,
Jiri
--
Jiri Benc
prev parent reply other threads:[~2016-02-02 15:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 10:13 [PATCH net-next 0/5] vxlan: cleanup headers and tx path Jiri Benc
2016-02-02 10:13 ` [PATCH net-next 1/5] vxlan: cleanup types Jiri Benc
2016-02-02 10:13 ` [PATCH net-next 2/5] vxlan: remove duplicated macros Jiri Benc
2016-02-02 10:13 ` [PATCH net-next 3/5] vxlan: restructure vxlan.h definitions Jiri Benc
2016-02-02 10:13 ` [PATCH net-next 4/5] vxlan: consolidate output route calculation Jiri Benc
2016-02-02 10:13 ` [PATCH net-next 5/5] vxlan: consolidate vxlan_xmit_skb and vxlan6_xmit_skb Jiri Benc
2016-02-02 14:57 ` Paolo Abeni
2016-02-02 15:06 ` Jiri Benc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160202160621.086e710c@griffin \
--to=jbenc@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).