From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH] of: of_mdio: Add marvell,88e1145 to whitelist of PHY compatibilities. Date: Wed, 3 Feb 2016 21:08:57 +0100 Message-ID: <20160203200857.GA10262@lunn.ch> References: <1454528129-6144-1-git-send-email-aaro.koskinen@iki.fi> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: David Miller , netdev@vger.kernel.org, Florian Fainelli , David Daney To: Aaro Koskinen Return-path: Received: from vps0.lunn.ch ([178.209.37.122]:49175 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753859AbcBCUJE (ORCPT ); Wed, 3 Feb 2016 15:09:04 -0500 Content-Disposition: inline In-Reply-To: <1454528129-6144-1-git-send-email-aaro.koskinen@iki.fi> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, Feb 03, 2016 at 09:35:29PM +0200, Aaro Koskinen wrote: > Commit ae461131960b ("of: of_mdio: Add a whitelist of PHY > compatibilities.") missed one compatible string used in in-tree DTBs: > in OCTEON, for selected boards, the kernel DTB pruning code will overwrite > the DTB compatible string with "marvell,88e1145", which is missing > from the whitelist. Add it. Does this overwriting means this compatibility is not visible in the current DTS files? Or did i miss it? At least for the Marvell SoCs i intend to submit a patch removing these compatible strings from the DTS files. Will you do the same for the OCTEON boards? > The patch fixes broken networking on EdgeRouter Lite. > > Fixes: ae461131960b ("of: of_mdio: Add a whitelist of PHY compatibilities.") > Signed-off-by: Aaro Koskinen Reviewed-by: Andrew Lunn Thanks Andrew > --- > drivers/of/of_mdio.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c > index 5648317..39c4be4 100644 > --- a/drivers/of/of_mdio.c > +++ b/drivers/of/of_mdio.c > @@ -154,6 +154,7 @@ static const struct of_device_id whitelist_phys[] = { > { .compatible = "marvell,88E1111", }, > { .compatible = "marvell,88e1116", }, > { .compatible = "marvell,88e1118", }, > + { .compatible = "marvell,88e1145", }, > { .compatible = "marvell,88e1149r", }, > { .compatible = "marvell,88e1310", }, > { .compatible = "marvell,88E1510", }, > -- > 2.4.0 >