From: Stephen Hemminger <stephen@networkplumber.org>
To: Nikolay Aleksandrov <razor@blackwall.org>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
netdev@vger.kernel.org, Roopa Prabhu <roopa@cumulusnetworks.com>,
virtualization@lists.linux-foundation.org, davem@davemloft.net
Subject: Re: [PATCH net-next] virtio_net: add ethtool support for set and get of settings
Date: Thu, 4 Feb 2016 10:53:07 +1100 [thread overview]
Message-ID: <20160204105307.62e6c934@samsung9> (raw)
In-Reply-To: <1454417480-28672-1-git-send-email-razor@blackwall.org>
On Tue, 2 Feb 2016 13:51:20 +0100
Nikolay Aleksandrov <razor@blackwall.org> wrote:
> +static bool virtnet_validate_speed(u32 speed)
> +{
> + switch (speed) {
> + case SPEED_10:
> + case SPEED_100:
> + case SPEED_1000:
> + case SPEED_2500:
> + case SPEED_5000:
> + case SPEED_10000:
> + case SPEED_20000:
> + case SPEED_25000:
> + case SPEED_40000:
> + case SPEED_50000:
> + case SPEED_56000:
> + case SPEED_100000:
> + case SPEED_UNKNOWN:
> + return true;
> + }
> +
> + return false;
> +}
Why limit to only known values. This switch() will get out of
date when some vendor introduces 64G or some other weird value.
prev parent reply other threads:[~2016-02-03 23:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 12:51 [PATCH net-next] virtio_net: add ethtool support for set and get of settings Nikolay Aleksandrov
2016-02-02 12:56 ` Nikolay Aleksandrov
2016-02-02 13:23 ` Michael S. Tsirkin
2016-02-02 13:52 ` Nikolay Aleksandrov
2016-02-02 14:10 ` Michael S. Tsirkin
2016-02-03 23:53 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160204105307.62e6c934@samsung9 \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=razor@blackwall.org \
--cc=roopa@cumulusnetworks.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).