From: David Miller <davem@davemloft.net>
To: subashab@codeaurora.org
Cc: netdev@vger.kernel.org, edumazet@google.com, ek@google.com,
hannes@stressinduktion.org
Subject: Re: [PATCH v2] ipv6: addrconf: Fix recursive spin lock call
Date: Sat, 06 Feb 2016 03:09:44 -0500 (EST) [thread overview]
Message-ID: <20160206.030944.1340132870709460187.davem@davemloft.net> (raw)
In-Reply-To: <f323a260f8bc358412de59575b058cdf.squirrel@www.codeaurora.org>
From: subashab@codeaurora.org
Date: Tue, 2 Feb 2016 02:11:10 -0000
> A rcu stall with the following backtrace was seen on a system with
> forwarding, optimistic_dad and use_optimistic set. To reproduce,
> set these flags and allow ipv6 autoconf.
>
> This occurs because the device write_lock is acquired while already
> holding the read_lock. Back trace below -
...
> v2: do addrconf_dad_kick inside read lock and then acquire write
> lock for ipv6_ifa_notify as suggested by Eric
>
> Fixes: 7fd2561e4ebdd ("net: ipv6: Add a sysctl to make optimistic
> addresses useful candidates")
>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Erik Kline <ek@google.com>
> Cc: Hannes Frederic Sowa <hannes@stressinduktion.org>
> Signed-off-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2016-02-06 8:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 2:11 [PATCH v2] ipv6: addrconf: Fix recursive spin lock call subashab
2016-02-02 14:02 ` Hannes Frederic Sowa
2016-02-02 14:06 ` Eric Dumazet
2016-02-06 8:09 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160206.030944.1340132870709460187.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ek@google.com \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
--cc=subashab@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).