From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: edumazet@google.com, netdev@vger.kernel.org, sara@sinodun.com,
ycheng@google.com, ncardwell@google.com
Subject: Re: [PATCH net-next] tcp: fastopen: call tcp_fin() if FIN present in SYNACK
Date: Sat, 06 Feb 2016 16:50:15 -0500 (EST) [thread overview]
Message-ID: <20160206.165015.2150156850444799755.davem@davemloft.net> (raw)
In-Reply-To: <1454786188.7627.339.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sat, 06 Feb 2016 11:16:28 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> When we acknowledge a FIN, it is not enough to ack the sequence number
> and queue the skb into receive queue. We also have to call tcp_fin()
> to properly update socket state and send proper poll() notifications.
>
> It seems we also had the problem if we received a SYN packet with the
> FIN flag set, but it does not seem an urgent issue, as no known
> implementation can do that.
>
> Fixes: 61d2bcae99f6 ("tcp: fastopen: accept data/FIN present in SYNACK message")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied, thanks.
prev parent reply other threads:[~2016-02-06 21:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 5:03 [PATCH net-next 0/2] tcp: fastopen: accept data/FIN present in SYNACK Eric Dumazet
2016-02-02 5:03 ` [PATCH net-next 1/2] tcp: fastopen: accept data/FIN present in SYNACK message Eric Dumazet
2016-02-02 5:03 ` [PATCH net-next 2/2] tcp: do not enqueue skb with SYN flag Eric Dumazet
2016-02-06 8:13 ` [PATCH net-next 0/2] tcp: fastopen: accept data/FIN present in SYNACK David Miller
2016-02-06 18:52 ` Eric Dumazet
2016-02-06 19:16 ` [PATCH net-next] tcp: fastopen: call tcp_fin() if FIN " Eric Dumazet
2016-02-06 21:50 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160206.165015.2150156850444799755.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=sara@sinodun.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).