* [PATCH] dscc4: Undefined signed int shift @ 2016-02-06 1:46 Michael McConville 2016-02-06 9:59 ` Francois Romieu 2016-02-13 11:10 ` David Miller 0 siblings, 2 replies; 3+ messages in thread From: Michael McConville @ 2016-02-06 1:46 UTC (permalink / raw) To: netdev; +Cc: Francois Romieu My analysis in the below mail applies, although the second part is unnecessary because i isn't used in arithmetic operations here: https://marc.info/?l=openbsd-tech&m=145377854103866&w=2 Thanks for your time. Signed-off-by: Michael McConville <mmcco@mykolab.com> --- drivers/net/wan/dscc4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wan/dscc4.c b/drivers/net/wan/dscc4.c index 7a72407..6292259 100644 --- a/drivers/net/wan/dscc4.c +++ b/drivers/net/wan/dscc4.c @@ -1626,7 +1626,7 @@ try: if (state & Xpr) { void __iomem *scc_addr; unsigned long ring; - int i; + unsigned int i; /* * - the busy condition happens (sometimes); ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dscc4: Undefined signed int shift 2016-02-06 1:46 [PATCH] dscc4: Undefined signed int shift Michael McConville @ 2016-02-06 9:59 ` Francois Romieu 2016-02-13 11:10 ` David Miller 1 sibling, 0 replies; 3+ messages in thread From: Francois Romieu @ 2016-02-06 9:59 UTC (permalink / raw) To: Michael McConville; +Cc: netdev Michael McConville <mmcco@mykolab.com> : > My analysis in the below mail applies, although the second part is > unnecessary because i isn't used in arithmetic operations here: > > https://marc.info/?l=openbsd-tech&m=145377854103866&w=2 > > Thanks for your time. Acked-by: Francois Romieu <romieu@fr.zoreil.com> For all practical matters it doesn't necessarily deserves to be fed through stable. -- Ueimor ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dscc4: Undefined signed int shift 2016-02-06 1:46 [PATCH] dscc4: Undefined signed int shift Michael McConville 2016-02-06 9:59 ` Francois Romieu @ 2016-02-13 11:10 ` David Miller 1 sibling, 0 replies; 3+ messages in thread From: David Miller @ 2016-02-13 11:10 UTC (permalink / raw) To: mmcco; +Cc: netdev, romieu From: Michael McConville <mmcco@mykolab.com> Date: Fri, 5 Feb 2016 20:46:25 -0500 > My analysis in the below mail applies, although the second part is > unnecessary because i isn't used in arithmetic operations here: > > https://marc.info/?l=openbsd-tech&m=145377854103866&w=2 > > Thanks for your time. > > Signed-off-by: Michael McConville <mmcco@mykolab.com> Applied, thanks. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-13 11:10 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-02-06 1:46 [PATCH] dscc4: Undefined signed int shift Michael McConville 2016-02-06 9:59 ` Francois Romieu 2016-02-13 11:10 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).