From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: brcmfmac: sdio: Increase the default timeouts a bit Date: Sat, 6 Feb 2016 11:59:10 +0000 (UTC) Message-ID: <20160206115910.BEE1F60226@smtp.codeaurora.org> References: <1453718849-3508-1-git-send-email-sjoerd.simons@collabora.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Hante Meuleman , linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Franky \(Zhenhui\) Lin" , brcm80211-dev-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org, Doug Anderson , Pieter-Paul Giesberts , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Brett Rudley , Arend van Spriel , Paul Stewart , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sjoerd Simons Return-path: In-Reply-To: <1453718849-3508-1-git-send-email-sjoerd.simons-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: netdev.vger.kernel.org > On a Radxa Rock2 board with a Ampak AP6335 (Broadcom 4339 core) it seems > the card responds very quickly most of the time, unfortunately during > initialisation it sometimes seems to take just a bit over 2 seconds to > respond. > > This results intialization failing with message like: > brcmf_c_preinit_dcmds: Retreiving cur_etheraddr failed, -52 > brcmf_bus_start: failed: -52 > brcmf_sdio_firmware_callback: dongle is not responding > > Increasing the timeout to allow for a bit more headroom allows the > card to initialize reliably. > > A quick search online after diagnosing/fixing this showed that Google > has a similar patch in their ChromeOS tree, so this doesn't seem > specific to the board I'm using. > > Signed-off-by: Sjoerd Simons > Reviewed-by: Julian Calaby > Acked-by: Arend van Spriel > Reviewed-by: Douglas Anderson Thanks, applied to wireless-drivers-next.git. Kalle Valo